Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable AI containers for tox -e all #672

Merged
merged 4 commits into from
Dec 10, 2024
Merged

Enable AI containers for tox -e all #672

merged 4 commits into from
Dec 10, 2024

Conversation

dcermak
Copy link
Collaborator

@dcermak dcermak commented Nov 26, 2024

[CI:TOXENVS] all

dirkmueller
dirkmueller requested changes Nov 26, 2024
View reviewed changes
Copy link
Member

@dirkmueller dirkmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AssertionError: IMAGES_AND_NAMES must have all containers from ALL_CONTAINERS

now we need to update tests/test/metadata as well

@dcermak dcermak requested a review from dirkmueller November 27, 2024 09:45
@dirkmueller dirkmueller merged commit e54ae2b into main Dec 10, 2024
48 of 51 checks passed
@dirkmueller dirkmueller deleted the ai-for-all branch December 10, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirkmueller dirkmueller dirkmueller approved these changes

@grisu48 grisu48 Awaiting requested review from grisu48

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcermak @dirkmueller