Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logfiles - get rid of external cat #144

Open
wants to merge 1 commit into
base: maintenance-classic
Choose a base branch
from

Conversation

PeterPitterling
Copy link
Contributor

No description provided.

Copy link
Member

@fmherschel fmherschel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@angelabriel: Here is fork vs fork (so not a real improvement in that direction), but less good to read. It's a bit more about code style.

@fmherschel
Copy link
Member

Maybe (after testing) would be OK, if we implement the read-from-file as a function. In that case the entire code gets more readable.

@PeterPitterling
Copy link
Contributor Author

@angelabriel: Here is fork vs fork (so not a real improvement in that direction), but less good to read. It's a bit more about code style.

There is a difference .. fork yes, but (<..) avoids execve
https://stackoverflow.com/questions/51937702/what-is-the-difference-between-cat-file-file-and-read-file-f

@fmherschel
Copy link
Member

I have added that code change for angi (crossported) for classic I would not like to add this code change as we would need to test that with all old SLES versions a customer still could run. Even, if they run an outdated SLES version I would not like to break their environment just for code style. For angi we could trust in versions could only be SLE15SP4 and newer. So that was more easy to test.
I vote for closing this PR (done for angi in the lib (commit #71762602444853197dbc7f07231f20de68ba8f26) and reject for classic).

@fmherschel fmherschel mentioned this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants