Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SUSEConnect -d error message on Public Cloud generic #267

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rjschwei
Copy link
Member

SUSEConnect -d is disabled on Public Cloud instances when registrecloudguest is present. This is to ensure that the correct de-registration action happens whether the system is connected to SCC or the update infrastructure. Initially this only mattered for PAYG. However with BYOS instances being able to connect to the update infrastructure we need the message to not refer to PAYG anymore.

@mssola
Copy link
Contributor

mssola commented Oct 3, 2024

What about a more generic message just in case we do something different in the future? Something like De-registration has been disabled on this context. (or better phrased...). Possibly with a link to documentation pointing at scenarios where de-register is disabled? (I don't know if that even exists)

@mssola mssola self-requested a review October 11, 2024 15:05
@rjschwei
Copy link
Member Author

What about a more generic message just in case we do something different in the future? Something like De-registration has been disabled on this context. (or better phrased...). Possibly with a link to documentation pointing at scenarios where de-register is disabled? (I don't know if that even exists)

Well, while nothing is impossible, replacing registercloudguest would be a rather large lift given its 10+ year history in our images. The idea behind using the command in the message is to avoid a really long explanation that would have to have a link to documentation which changes quite frequently compared to registercloudguest

@mssola
Copy link
Contributor

mssola commented Oct 18, 2024

Fair enough. Could you rebase your commit given that there are conflicts now?

SUSEConnect -d is disabled on Public Cloud instances when registrecloudguest
is present. This is to ensure that the correct de-registration action happens
whether the system is connected to SCC or the update infrastructure.
Initially this only mattered for PAYG. However with BYOS instances being
able to connect to the update infrastructure we need the message to not refer
to PAYG anymore.
@rjschwei
Copy link
Member Author

Fair enough. Could you rebase your commit given that there are conflicts now?

Done.

Not sure about the test failure. And will need help with that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants