Write diagnostics/error messages to stderr #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Alex P. <[email protected]>
Add --set-labels to register command to set labels at registration time on SCC
This allows the internal configuration of SUSEConnect to understand on which kind of server it's trying to connect. This is relevant in case we want to perform some operations on SCC and some others on RMT. Signed-off-by: Miquel Sabaté Solà <[email protected]>
Fixes bsc#1231185 Signed-off-by: Miquel Sabaté Solà <[email protected]>
Signed-off-by: Miquel Sabaté Solà <[email protected]>
…on-pubcloud Do not generate docker configuration on pubcloud
The parsing of CLI arguments and how these are passed through the internal SCC client, zypper and other tools is not ideal and needs to be re-worked quite urgently. This is why other silly bugs have appeared in which we are not passing the correct arguments to our backend code. Until this rework is not done, let's simply apply this quick fix which simply passes the `--gpg-auto-import-keys` flag to the zypper backend when finding product packages. Fixes bsc#1231328 Signed-off-by: Miquel Sabaté Solà <[email protected]>
Honor auto-import-gpg-keys flag on migration
Like a good POSIX program
|
Awesome Will, I take a look right away |
|
I asked Robert and Ignaz if they see problems with this |
|
This can proceed from my POV, we have SUSE-Enceladus/cloud-regionsrv-client#223 to accommodate this change. |
|
@wstephenson could you rebase this PR? Then I will review it right away as @rjschwei gave a green light to this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like a good POSIX program
https://bugzilla.suse.com/show_bug.cgi?id=1233147 describes a complaint from Amazon that the error output on
--json --statuswhen the system registration is not found on SCC is not in json format. The underlying problem is that the error messages are all output on stdout. The user should check the return code of the process before interpreting stdout.Nevertheless, it's good practice to put error messages and diagnostics on stdout.
I'm unsure whether the error output on Register (lines 290ff) and deRegister (233ff) with
--jsoncan be put on stderr, because the code is outputting the result of the API operation as a json object, and consumers may rely on this behaviour.