Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting up and Managing NetworkManager #400

Open
wants to merge 59 commits into
base: main
Choose a base branch
from

Conversation

harneshalaka
Copy link
Contributor

Description

Smartdoc describing installation, configuration, logging, and troubleshooting NetworkManager.

Are there any relevant issues/feature requests?

  • bsc#...
  • jsc#SLE-...

Is this (based on) existing content?

[* old xml:id...

@lvicoun lvicoun self-requested a review December 16, 2024 10:32
Copy link
Contributor

@lvicoun lvicoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Shalake for the new fresh insight on this topic :) however, I'd like to propose changes to the article and would like to merge with the SL Micro into a single assembly. Happy to help with the merging :)

concepts/networkmanager-nmcli-concept.xml Outdated Show resolved Hide resolved
concepts/networkmanager-nmcli-concept.xml Outdated Show resolved Hide resolved
articles/SLES-networkmanager-nmcli.asm.xml Outdated Show resolved Hide resolved
tasks/networkmanager-nmcli-install.xml Outdated Show resolved Hide resolved
articles/SLES-networkmanager-nmcli.asm.xml Show resolved Hide resolved
tasks/networkmanager-nmcli-monitor.xml Outdated Show resolved Hide resolved
tasks/networkmanager-nmcli-troubleshoot.xml Outdated Show resolved Hide resolved
tasks/networkmanager-nmcli-troubleshoot.xml Outdated Show resolved Hide resolved
<screen>
nmcli device wifi rescan
nmcli device wifi list
</screen>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here I miss what to do if the reconnection does not help.

tasks/networkmanager-nmcli-modify.xml Outdated Show resolved Hide resolved
Copy link
Contributor

@taroth21 taroth21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harneshalaka : Many thanks, I have added my comments and suggestions now.

concepts/networkmanager-nmcli-concept.xml Outdated Show resolved Hide resolved
articles/SLES-networkmanager-nmcli.asm.xml Outdated Show resolved Hide resolved
articles/SLES-networkmanager-nmcli.asm.xml Outdated Show resolved Hide resolved
articles/SLES-networkmanager-nmcli.asm.xml Outdated Show resolved Hide resolved
concepts/networkmanager-nmcli-concept.xml Outdated Show resolved Hide resolved
<step><para>To use DHCP, run the command:</para>
<screen>nmcli connection modify <replaceable>NEWCONNECTION</replaceable> ipv4.method auto</screen></step>
<step><para>To configure a static IPv4 address, network mask, default gateway, DNS servers, and search domain, run the command:</para>
<screen>nmcli connection modify <replaceable>NEWCONNECTION</replaceable> ipv4.method manual ipv4.addresses 192.0.2.1/24 ipv4.gateway 192.0.2.254 ipv4.dns 192.0.2.200 ipv4.dns-search example.com</screen>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check and make sure to follow our guidelines about example items, see https://documentation.suse.com/style/current/single-html/docu_styleguide/#sec-name

tasks/networkmanager-nmcli-configure.xml Outdated Show resolved Hide resolved
tasks/networkmanager-nmcli-configure.xml Outdated Show resolved Hide resolved
tasks/networkmanager-nmcli-install.xml Outdated Show resolved Hide resolved
tasks/networkmanager-nmcli-install.xml Outdated Show resolved Hide resolved
Copy link
Contributor

@dariavladykina dariavladykina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Please see some suggestions from me here. Thanks!

<!-- S T R U C T U R E -->
<structure renderas="article" xml:id="networkmanager-nmcli" xml:lang="en">
<merge>
<title>Setting up and Managing Network Connections using &nm;</title>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<title>Setting up and Managing Network Connections using &nm;</title>
<title>Setting Up and Managing Network Connections Using &nm;</title>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harneshalaka : This fix for the title was not merged yet, in the PDF that I built after your latest fixes from today the article title still reads: 'Setting up and Managing Network Connections using NetworkManager' . Please change as suggested by @dariavladykina - thanks!

articles/SLES-networkmanager-nmcli.asm.xml Outdated Show resolved Hide resolved
articles/SLES-networkmanager-nmcli.asm.xml Outdated Show resolved Hide resolved
articles/SLES-networkmanager-nmcli.asm.xml Outdated Show resolved Hide resolved
articles/SLES-networkmanager-nmcli.asm.xml Outdated Show resolved Hide resolved
tasks/networkmanager-nmcli-logging.xml Outdated Show resolved Hide resolved
tasks/networkmanager-nmcli-logging.xml Outdated Show resolved Hide resolved
tasks/networkmanager-nmcli-logging.xml Outdated Show resolved Hide resolved
tasks/networkmanager-nmcli-configure.xml Outdated Show resolved Hide resolved
tasks/networkmanager-nmcli-configure.xml Outdated Show resolved Hide resolved
harneshalaka and others added 19 commits December 19, 2024 20:43
Fixed editorial changes.

Co-authored-by: Daria Vladykina <[email protected]>
Fixed editorial comments.

Co-authored-by: Daria Vladykina <[email protected]>
Co-authored-by: Tanja Roth <[email protected]>
Fixed editorial comments.

Co-authored-by: Daria Vladykina <[email protected]>
Fixed editorial comments.

Co-authored-by: Daria Vladykina <[email protected]>
Fixed editorial comments.

Co-authored-by: Daria Vladykina <[email protected]>
Fixed editorial comments.

Co-authored-by: Daria Vladykina <[email protected]>
Fixed editorial comments.

Co-authored-by: Daria Vladykina <[email protected]>
Copy link
Contributor

@taroth21 taroth21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harneshalaka : Many thanks for integrating all the feedback! My remaining feedback may look much, but it is actually mostly nitpicks. I provided it in form of suggestions wherever possible, so hopefully applying it should not cause too much work (I hope I got the markup correct everywhere - if not, I'm to blame). ;)

concepts/networkmanager-nmcli-concept.xml Outdated Show resolved Hide resolved
concepts/networkmanager-nmcli-concept.xml Outdated Show resolved Hide resolved
references/networkmanager-nm-monitor.xml Outdated Show resolved Hide resolved
tasks/networkmanager-nmcli-conf-nwbehavior.xml Outdated Show resolved Hide resolved
tasks/networkmanager-nmcli-conf-nwbehavior.xml Outdated Show resolved Hide resolved
tasks/networkmanager-nmcli-configure.xml Show resolved Hide resolved
references/networkmanager-nm-modify.xml Outdated Show resolved Hide resolved
references/networkmanager-nm-modify.xml Outdated Show resolved Hide resolved
references/networkmanager-nm-enabledisable.xml Outdated Show resolved Hide resolved
references/networkmanager-nm-enabledisable.xml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants