Skip to content

Sharne/enhancevmsecurity #1770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Sep 28, 2024
Merged

Sharne/enhancevmsecurity #1770

merged 26 commits into from
Sep 28, 2024

Conversation

harneshalaka
Copy link
Contributor

@harneshalaka harneshalaka commented Sep 24, 2024

PR creator: Description

Added new chapter on Enhancing VM Security.

PR creator: Are there any relevant issues/feature requests?

  • bsc#...
  • jsc#PED-10565

PR creator: Which product versions do the changes apply to?

When opening a PR, check all versions of the documentation that your PR applies to.

[x] SLE 15 next/openSUSE Leap next (current main, no backport necessary)
[x] SLE 15 SP6/openSUSE Leap 15.6

Copy link
Collaborator

@dariavladykina dariavladykina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Shalaka, please see some suggestions here.
I've added some comments where it was possible to add them. They are mainly about sentence-style capitalization of all headings and no indentation in screens.
Thanks!

Copy link
Collaborator

@dariavladykina dariavladykina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, sending back some suggestions of mine. Thanks!

harneshalaka and others added 13 commits September 26, 2024 15:25
Co-authored-by: Daria Vladykina <[email protected]>
Co-authored-by: Daria Vladykina <[email protected]>
Co-authored-by: Daria Vladykina <[email protected]>
Co-authored-by: Daria Vladykina <[email protected]>
Co-authored-by: Daria Vladykina <[email protected]>
Co-authored-by: Daria Vladykina <[email protected]>
Co-authored-by: Daria Vladykina <[email protected]>
Co-authored-by: Daria Vladykina <[email protected]>
Co-authored-by: Daria Vladykina <[email protected]>
Co-authored-by: Daria Vladykina <[email protected]>
Co-authored-by: Daria Vladykina <[email protected]>
Co-authored-by: Daria Vladykina <[email protected]>
Copy link
Collaborator

@dariavladykina dariavladykina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, please add alternative text to all images to help our SEO. Thanks!

Copy link
Collaborator

@dariavladykina dariavladykina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@taroth21
Copy link
Contributor

taroth21 commented Sep 27, 2024

@harneshalaka : Thanks, I just fixed two minor issues directly that I found by looking at the PDF. All fine from my side now, please go ahead and squash and merge, then we can backport this to maintenance/SLE15SP6 next week. Many thanks!

Copy link
Contributor

@taroth21 taroth21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Good to go!

@harneshalaka harneshalaka merged commit d10d858 into main Sep 28, 2024
9 checks passed
taroth21 added a commit that referenced this pull request Oct 4, 2024
Added a new chapter "Enhancing virtual machine security with AMD SEV-SNP"

---------

Co-authored-by: Daria Vladykina <[email protected]>
Co-authored-by: Tanja Roth <[email protected]>
(cherry picked from commit d10d858)
@taroth21
Copy link
Contributor

taroth21 commented Oct 4, 2024

Backported to maintenance/SLE15SP6 with

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants