-
Notifications
You must be signed in to change notification settings - Fork 253
Sharne/enhancevmsecurity #1770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sharne/enhancevmsecurity #1770
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Shalaka, please see some suggestions here.
I've added some comments where it was possible to add them. They are mainly about sentence-style capitalization of all headings and no indentation in screens.
Thanks!
f2d2b56
to
7c37ec3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, sending back some suggestions of mine. Thanks!
Co-authored-by: Daria Vladykina <[email protected]>
Co-authored-by: Daria Vladykina <[email protected]>
Co-authored-by: Daria Vladykina <[email protected]>
Co-authored-by: Daria Vladykina <[email protected]>
Co-authored-by: Daria Vladykina <[email protected]>
Co-authored-by: Daria Vladykina <[email protected]>
Co-authored-by: Daria Vladykina <[email protected]>
Co-authored-by: Daria Vladykina <[email protected]>
Co-authored-by: Daria Vladykina <[email protected]>
Co-authored-by: Daria Vladykina <[email protected]>
Co-authored-by: Daria Vladykina <[email protected]>
Co-authored-by: Daria Vladykina <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, please add alternative text to all images to help our SEO. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@harneshalaka : Thanks, I just fixed two minor issues directly that I found by looking at the PDF. All fine from my side now, please go ahead and squash and merge, then we can backport this to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Good to go!
Added a new chapter "Enhancing virtual machine security with AMD SEV-SNP" --------- Co-authored-by: Daria Vladykina <[email protected]> Co-authored-by: Tanja Roth <[email protected]> (cherry picked from commit d10d858)
PR creator: Description
Added new chapter on Enhancing VM Security.
PR creator: Are there any relevant issues/feature requests?
PR creator: Which product versions do the changes apply to?
When opening a PR, check all versions of the documentation that your PR applies to.
[x] SLE 15 next/openSUSE Leap next (current main, no backport necessary)
[x] SLE 15 SP6/openSUSE Leap 15.6