No config - move even more things out of Config class #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now we use a dict to quickly search for the codestreams without resorting to a list. Signed-off-by: Marcos Paulo de Souza <[email protected]>
Some problems can happen with remote branches, but we don't care. Signed-off-by: Marcos Paulo de Souza <[email protected]>
Fixing small stuff, not functional changes expected. Signed-off-by: Marcos Paulo de Souza <[email protected]>
And simplify the Config class, and the other classes that inherit it. Also fix some pylint issues found. Signed-off-by: Marcos Paulo de Souza <[email protected]>
And also classify the codestreams when grouping codestreams after the extract. Signed-off-by: Marcos Paulo de Souza <[email protected]>
Signed-off-by: Marcos Paulo de Souza <[email protected]>
Signed-off-by: Marcos Paulo de Souza <[email protected]>
Sometimes, after a livepatch is taking long to finish, some codestrams can get out of support, so in order to prepare the tests correctly, drop these stale codestreams once we found them. Signed-off-by: Marcos Paulo de Souza <[email protected]>
Reported by pylint. Signed-off-by: Marcos Paulo de Souza <[email protected]>
Now IBS only contains two arguments, so remove the stale argument. Signed-off-by: Marcos Paulo de Souza <[email protected]>
This helps us to download missing codestreams. We still need to check all configs, but we can do that in the future, since we don't really have to deal with multiple places with different configs that much. Signed-off-by: Marcos Paulo de Souza <[email protected]>
fgyanz
reviewed
Nov 29, 2024
| subprocess.check_output(["/usr/bin/git", "-C", self.kern_src, "fetch", | ||
| "--quiet", "--tags", "origin"] + | ||
| subprocess.check_output(["/usr/bin/git", "-C", str(self.kern_src), "fetch", | ||
| "--quiet", "--tags", "--force", "origin"] + |
There was a problem hiding this comment.
Can you clarify why do we need force here? Is there any advantage to the current behavior? I'm wondering if this will have a negative effect on performance and when fetching from multiple instances of klp-build at the same time.
There was a problem hiding this comment.
Sure, there was one error when fetching changes from kernel-sources related to so stale/removed tags, IIRC, but as we don't care much about those I just added force so it just bypasses it, instead of errorring out.
There was a problem hiding this comment.
ah I see! Alright, makes sense :)
|
LGTM! Thanks for all the work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we are mostly done: a ton of things now are moved into util and Codestream classes