Change .so load policy and fix symbol visibility problems #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, libpulp used RTLD_LAZY in dlopen, which resulted in livepatch that should have failed to apply being applied. In SLE-15-SP4, those patches seems to work regardless of that, but in SP5 it result in problems. Hence, change this policy to RTLD_NOW to force all symbols to be loaded by the linker at patch load time. Also, this commit now encode the symbol references on packer even if not specified in .dsc by capturing it from the .json dumps, which should improve the support for strong externalizations. Signed-off-by: Giuliano Belinassi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, libpulp used RTLD_LAZY in dlopen, which resulted in livepatch that should have failed to apply being applied. In SLE-15-SP4, those patches seems to work regardless of that, but in SP5 it result in problems. Hence, change this policy to RTLD_NOW to force all symbols to be loaded by the linker at patch load time.
Also, this commit now encode the symbol references on packer even if not specified in .dsc by capturing it from the .json dumps, which should improve the support for strong externalizations.