Verify TLS by default to avoid warnings #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardobranco777
force-pushed
the
verify_tls
branch
from
3513ffb
to
5f61e8a
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #299 +/- ##
==========================================
+ Coverage 79.01% 79.10% +0.09%
==========================================
Files 21 21
Lines 1596 1603 +7
==========================================
+ Hits 1261 1268 +7
Misses 335 335
☔ View full report in Codecov by Sentry. |
grisu48
approved these changes
Aug 15, 2023
asmorodskyi
reviewed
Aug 28, 2023
| @@ -16,7 +16,7 @@ pylint: | |||
|
|
|||
| .PHONY: flake8 | |||
| flake8: | |||
| flake8 --max-line-length=$(LINE_MAX) . | |||
| flake8 --max-line-length=$(LINE_MAX) $(FILES) tests/*.py | |||
There was a problem hiding this comment.
I think we should keep nice and tidy model which we HAD , with variables . if FILES variable is not enough better create one more variable ...
asmorodskyi
reviewed
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verify TLS by default to avoid SSLError warnings when connecting to openQA. These warnings can't be disabled in
requestsfor openQA only because doing so would also disable them when connecting to cloud providers.