Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include ignore field in instances.json #301

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Conversation

grisu48
Copy link
Collaborator

@grisu48 grisu48 commented Aug 22, 2023

The instances.json path should also include the ignore field to allow external applications to hide ignored instances.

The instances.json path should also include the ignore field to allow
external applications to hide ignored instances.
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (bad7f7c) 78.96% compared to head (c9c111b) 78.96%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #301   +/-   ##
=======================================
  Coverage   78.96%   78.96%           
=======================================
  Files          21       21           
  Lines        1607     1607           
=======================================
  Hits         1269     1269           
  Misses        338      338           
Files Changed Coverage Δ
ocw/views.py 57.14% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ricardobranco777 ricardobranco777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grisu48 grisu48 merged commit 20a670c into SUSE:master Aug 23, 2023
10 checks passed
@grisu48 grisu48 deleted the instances branch August 23, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants