Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #302

Merged
merged 5 commits into from
Aug 30, 2023
Merged

Fixes #302

merged 5 commits into from
Aug 30, 2023

Conversation

ricardobranco777
Copy link
Collaborator

@ricardobranco777 ricardobranco777 commented Aug 29, 2023

This PR:

  • Tidies the Selenium test to allow proper cleanup
  • Fixes SSL warning for valid certificates with openQA client
  • Fixes wrong calls to log_err.
  • Fixes broad exception catching of ClientError for EC2.
  • Fixes broad exception catching of HttpError for GCE.

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Patch coverage: 47.05% and project coverage change: -0.16% ⚠️

Comparison is base (20a670c) 78.96% compared to head (7da5a49) 78.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #302      +/-   ##
==========================================
- Coverage   78.96%   78.81%   -0.16%     
==========================================
  Files          21       21              
  Lines        1607     1614       +7     
==========================================
+ Hits         1269     1272       +3     
- Misses        338      342       +4     
Files Changed Coverage Δ
ocw/lib/ec2.py 78.43% <0.00%> (-0.59%) ⬇️
ocw/lib/gce.py 89.86% <0.00%> (-1.24%) ⬇️
ocw/lib/openqa.py 98.11% <100.00%> (+0.11%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

grisu48
grisu48 previously approved these changes Aug 29, 2023
asmorodskyi
asmorodskyi previously approved these changes Aug 30, 2023
Copy link
Collaborator

@asmorodskyi asmorodskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@asmorodskyi asmorodskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@ricardobranco777 ricardobranco777 merged commit fde086c into SUSE:master Aug 30, 2023
@ricardobranco777 ricardobranco777 deleted the fixes branch August 30, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants