forked from containers/podman
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go.mod: bump buildah to 1.35.4 #1
Open
danishprakash
wants to merge
7
commits into
SUSE:suse-v4.9.5
Choose a base branch
from
danishprakash:suse-v4.9.5-buildah-1.35.4
base: suse-v4.9.5
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
go.mod: bump buildah to 1.35.4 #1
danishprakash
wants to merge
7
commits into
SUSE:suse-v4.9.5
from
danishprakash:suse-v4.9.5-buildah-1.35.4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danish Prakash <[email protected]>
Signed-off-by: Danish Prakash <[email protected]>
pkg/specgen: type cast attributes to conform to new definition Signed-off-by: Danish Prakash <[email protected]>
Signed-off-by: Danish Prakash <[email protected]>
..and deprecated methods Signed-off-by: Danish Prakash <[email protected]>
This field drags in a dependency on CNI and thereby blocks us from disabling CNI support via a build tag [NO NEW TESTS NEEDED] Signed-off-by: Dan Čermák <[email protected]> Signed-off-by: Danish Prakash <[email protected]>
Signed-off-by: Danish Prakash <[email protected]>
dcermak
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for splitting out the various back porting steps!
I'd only suggest to amend the commit messages and add a bit more info whether this was a manual step or whether this commit needs a re-vendor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Danish Prakash [email protected]