Conversation
mpagot
force-pushed
the
ansible_lint_fix
branch
from
ef5b905 to
db3f66a
Compare
mpagot
force-pushed
the
ansible_lint_fix
branch
from
db3f66a to
3611e3d
Compare
mpagot
force-pushed
the
ansible_lint_fix
branch
from
3611e3d to
3641f10
Compare
|
|
||
| static-ansible-syntax: | ||
| @find ansible/playbooks -type f -iname "*.yaml" -maxdepth 1 -exec ansible-playbook -l all -vvvv -i terraform/azure/inventory.yaml --syntax-check {} + | ||
| @find ansible/playbooks/ -type f -iname "*.yaml" -and ! -name "registration_role.yaml" -maxdepth 1 -exec ansible-playbook -l all -vvvv -i terraform/azure/inventory.yaml --syntax-check {} + |
Collaborator
There was a problem hiding this comment.
The other check (the one in static-ansible-yaml) calls a script with only one find (and some variables). Wouldn't it make sense to also turn this check into a script in tools/?
Collaborator
Author
There was a problem hiding this comment.
I decided to focus this PR on yamllint and leave all the work about ansible-playbook ``syntax-check for a next PR. Yes I agree it make sense to move this one too to a dedicated script.
alvarocarvajald
approved these changes
Nov 22, 2023
Collaborator
alvarocarvajald
left a comment
alvarocarvajald
left a comment
There was a problem hiding this comment.
LGTM. Just a question.
Fix Makefile about all the Ansible targets, they now catch all relevant files. Fix all the warning reported by yamllint. Add a github action to lint the Ansible code with yamllint.
mpagot
force-pushed
the
ansible_lint_fix
branch
from
3641f10 to
af53d94
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Makefile about all the Ansible targets, they now catch all relevant files.
Fix all the warning reported by yamllint.
Add a github action to lint the Ansible code with yamllint.
Ticket : TEAM-7184
Verification: is the pipeline execution in this PR