-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove hardcoded HANA installer parameters #195
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be fixed, because path does not contain {{ sap_hana_install_sid | lower }} , instead it is fixed "hdb"
Example of my H01 hana:
/usr/sap/H01/SYS/global/hdb/custom/config/global.ini
@@ -53,7 +64,7 @@ | |||
block: | |||
- name: Ensure ha_dr_provider_SAPHanaSR section exists in global.ini | |||
community.general.ini_file: | |||
path: /usr/sap/HDB/SYS/global/hdb/custom/config/global.ini | |||
path: /usr/sap/{{ sap_hana_install_sid }}/SYS/global/{{ sap_hana_install_sid | lower }}/custom/config/global.ini |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be fixed, because path does not contain {{ sap_hana_install_sid | lower }} , instead it is fixed "hdb"
Example of my H01 hana:
/usr/sap/H01/SYS/global/hdb/custom/config/global.ini
Remove hardcoded parameters from sap-hana-system-replication-hooks
670b462
to
0f21287
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Remove hardcoded parameters from sap-hana-system-replication-hooks
Ticket: TEAM-8674
Verifications:
HanaSR
sle-15-SP4-HanaSr-Azure-Byos-x86_64-Build15-SP4_2023-12-19T05:03:09Z-hanasr_azure_test_sapconf_msi@64bit
http://openqaworker15.qa.suse.cz/tests/273299 🟢 failure is later after the end of the
qe-sap-deployment
deployhttp://openqaworker15.qa.suse.cz/tests/273370 after pr_fix
- sle-15-SP4-HanaSr-Aws-Byos-x86_64-Build15-SP4_2023-12-19T05:03:09Z-hanasr_aws_test_saptune@64bit
- sle-15-SP5-Qesap-Azure-Byos-x86_64-BuildLATEST_AZURE_SLE15_5_BYOS-qesap_azure_sapconf_test@64bit
"msg": "Timed out waiting for last boot time check (timeout=900)",
qesap regression
sle-15-SP5-Qesap-Gcp-Byos-x86_64-BuildLATEST_GCE_SLE15_5_BYOS-qesap_gcp_sbd@64bit
sle-15-SP5-Qesap-Azure-Byos-x86_64-BuildLATEST_AZURE_SLE15_5_BYOS-qesap_azure_saptune_test@64bit
sle-15-SP5-Qesap-Aws-Byos-x86_64-BuildLATEST_AWS_SLE15_5_BYOS-qesap_aws_sbd@64bit
sle-15-SP5-Qesap-Aws-Byos-x86_64-BuildLATEST_AWS_SLE15_5_BYOS-qesap_aws_saptune_test@64bit