Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded HANA installer parameters #195

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

mpagot
Copy link
Collaborator

@mpagot mpagot commented Dec 11, 2023

Remove hardcoded parameters from sap-hana-system-replication-hooks

Ticket: TEAM-8674

Verifications:

HanaSR

sle-15-SP4-HanaSr-Azure-Byos-x86_64-Build15-SP4_2023-12-19T05:03:09Z-hanasr_azure_test_sapconf_msi@64bit

http://openqaworker15.qa.suse.cz/tests/273299 🟢 failure is later after the end of the qe-sap-deployment deploy

http://openqaworker15.qa.suse.cz/tests/273370 after pr_fix

- sle-15-SP4-HanaSr-Aws-Byos-x86_64-Build15-SP4_2023-12-19T05:03:09Z-hanasr_aws_test_saptune@64bit

ERROR    OUTPUT:              "stderr": "\u001b[31mERROR\u001b[0m: (unpack_resources) \terror: Resource start-up disabled since no STONITH resources have been defined\n\u001b[31mERROR\u001b[0m: (unpack_resources) \terror: Either configure some or disable STONITH with the stonith-enabled option\n\u001b[31mERROR\u001b[0m: (unpack_resources) \terror: NOTE: Clusters with shared data need STONITH to ensure data integrity\n\u001b[31mERROR\u001b[0m: crm_verify: Errors found during check: config not valid",
ERROR    OUTPUT:              "stderr_lines": [
ERROR    OUTPUT:                  "\u001b[31mERROR\u001b[0m: (unpack_resources) \terror: Resource start-up disabled since no STONITH resources have been defined",
ERROR    OUTPUT:                  "\u001b[31mERROR\u001b[0m: (unpack_resources) \terror: Either configure some or disable STONITH with the stonith-enabled option",
ERROR    OUTPUT:                  "\u001b[31mERROR\u001b[0m: (unpack_resources) \terror: NOTE: Clusters with shared data need STONITH to ensure data integrity",
ERROR    OUTPUT:                  "\u001b[31mERROR\u001b[0m: crm_verify: Errors found during check: config not valid"
ERROR    OUTPUT:              ],
ERROR    OUTPUT:              "stdout": "\u001b[33mWARNING\u001b[0m: (cluster_status) \twarning: Fencing and resource management disabled due to lack of quorum",

- sle-15-SP5-Qesap-Azure-Byos-x86_64-BuildLATEST_AZURE_SLE15_5_BYOS-qesap_azure_sapconf_test@64bit

qesap regression

sle-15-SP5-Qesap-Gcp-Byos-x86_64-BuildLATEST_GCE_SLE15_5_BYOS-qesap_gcp_sbd@64bit

sle-15-SP5-Qesap-Azure-Byos-x86_64-BuildLATEST_AZURE_SLE15_5_BYOS-qesap_azure_saptune_test@64bit

sle-15-SP5-Qesap-Aws-Byos-x86_64-BuildLATEST_AWS_SLE15_5_BYOS-qesap_aws_sbd@64bit

sle-15-SP5-Qesap-Aws-Byos-x86_64-BuildLATEST_AWS_SLE15_5_BYOS-qesap_aws_saptune_test@64bit

ERROR    OUTPUT:                  "\u001b[33mWARNING\u001b[0m: (cluster_status) \twarning: Fencing and resource management disabled due to lack of quorum",
ERROR    OUTPUT:                  "\u001b[31mERROR\u001b[0m: (unpack_resources) \terror: Resource start-up disabled since no STONITH resources have been defined",
ERROR    OUTPUT:                  "\u001b[31mERROR\u001b[0m: (unpack_resources) \terror: Either configure some or disable STONITH with the stonith-enabled option",
ERROR    OUTPUT:                  "\u001b[31mERROR\u001b[0m: (unpack_resources) \terror: NOTE: Clusters with shared data need STONITH to ensure data integrity",
ERROR    OUTPUT:                  "\u001b[31mERROR\u001b[0m: crm_verify: Errors found during check: config not valid"

Copy link
Collaborator

@alvarocarvajald alvarocarvajald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@marcelmamula marcelmamula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be fixed, because path does not contain {{ sap_hana_install_sid | lower }} , instead it is fixed "hdb"

Example of my H01 hana:
/usr/sap/H01/SYS/global/hdb/custom/config/global.ini

@@ -53,7 +64,7 @@
block:
- name: Ensure ha_dr_provider_SAPHanaSR section exists in global.ini
community.general.ini_file:
path: /usr/sap/HDB/SYS/global/hdb/custom/config/global.ini
path: /usr/sap/{{ sap_hana_install_sid }}/SYS/global/{{ sap_hana_install_sid | lower }}/custom/config/global.ini
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be fixed, because path does not contain {{ sap_hana_install_sid | lower }} , instead it is fixed "hdb"

Example of my H01 hana:
/usr/sap/H01/SYS/global/hdb/custom/config/global.ini

Remove hardcoded parameters from sap-hana-system-replication-hooks
Copy link
Contributor

@lilyeyes lilyeyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM.

Copy link
Collaborator

@lpalovsky lpalovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpagot mpagot merged commit 2a6f1dd into SUSE:main Jan 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants