Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable use_suseconnect argument for registration.yaml #203

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Enable use_suseconnect argument for registration.yaml #203

merged 1 commit into from
Jan 31, 2024

Conversation

BillAnastasiadis
Copy link
Collaborator

@BillAnastasiadis BillAnastasiadis commented Jan 29, 2024 •
edited
Loading

Change the registration playbook to take an optional argument use_suseconnect, similar to the registration role.

NOTE: merge together with os-autoinst/os-autoinst-distri-opensuse#18544

@BillAnastasiadis BillAnastasiadis mentioned this pull request Jan 30, 2024
Merged
mpagot
mpagot approved these changes Jan 30, 2024
View reviewed changes
Copy link
Collaborator

@mpagot mpagot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

marcelmamula
marcelmamula reviewed Jan 30, 2024
View reviewed changes
ansible/playbooks/registration.yaml
@@ -4,6 +4,9 @@
become: true
become_user: root

vars:
use_suseconnect: false # Set to false unless specified
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vars should come from defaults/main.yml

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the registration role that we use in some tests instead of the normal registration playbook, It is defined there. But we don't have defaults/main.yml for non-role playbooks (like this registration.yaml playbook), and this variable is unique to this playbook - not used anywhere else.

@BillAnastasiadis BillAnastasiadis changed the title WIP: Enable use_suseconnect argument for registration.yaml Enable use_suseconnect argument for registration.yaml Jan 30, 2024
alvarocarvajald
alvarocarvajald approved these changes Jan 30, 2024
View reviewed changes
Copy link
Collaborator

@alvarocarvajald alvarocarvajald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BillAnastasiadis BillAnastasiadis merged commit d58b6f6 into SUSE:main Jan 31, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelmamula marcelmamula marcelmamula left review comments

@mpagot mpagot mpagot approved these changes

@alvarocarvajald alvarocarvajald alvarocarvajald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BillAnastasiadis @alvarocarvajald @mpagot @marcelmamula