Conversation
BillAnastasiadis
force-pushed
the
gcp_native
branch
from
88827de to
0134153
Compare
BillAnastasiadis
temporarily deployed
to
production
GitHub Actions
Inactive
BillAnastasiadis
temporarily deployed
to
production
GitHub Actions
Inactive
BillAnastasiadis
temporarily deployed
to
production
GitHub Actions
Inactive
BillAnastasiadis
force-pushed
the
gcp_native
branch
from
0134153 to
116ddd7
Compare
BillAnastasiadis
temporarily deployed
to
production
GitHub Actions
Inactive
BillAnastasiadis
temporarily deployed
to
production
GitHub Actions
Inactive
BillAnastasiadis
temporarily deployed
to
production
GitHub Actions
Inactive
BillAnastasiadis
force-pushed
the
gcp_native
branch
from
116ddd7 to
effe2a8
Compare
BillAnastasiadis
temporarily deployed
to
production
GitHub Actions
Inactive
BillAnastasiadis
temporarily deployed
to
production
GitHub Actions
Inactive
BillAnastasiadis
temporarily deployed
to
production
GitHub Actions
Inactive
BillAnastasiadis
force-pushed
the
gcp_native
branch
from
effe2a8 to
123a69a
Compare
BillAnastasiadis
temporarily deployed
to
production
GitHub Actions
Inactive
BillAnastasiadis
temporarily deployed
to
production
GitHub Actions
Inactive
BillAnastasiadis
temporarily deployed
to
production
GitHub Actions
Inactive
BillAnastasiadis
changed the title
mpagot
reviewed
Sep 6, 2024
BillAnastasiadis
force-pushed
the
gcp_native
branch
from
123a69a to
4f98e47
Compare
BillAnastasiadis
temporarily deployed
to
production
GitHub Actions
Inactive
BillAnastasiadis
temporarily deployed
to
production
GitHub Actions
Inactive
BillAnastasiadis
temporarily deployed
to
production
GitHub Actions
Inactive
mpagot
reviewed
Sep 6, 2024
|
|
||
| - name: Set primary and secondary hostnames | ||
| ansible.builtin.set_fact: | ||
| primary_hostname: "{{ groups['hana'][0] }}" |
Collaborator
There was a problem hiding this comment.
We use similar query to calculate is_primary. Differences are:
- all of them calculate it ad playbook level and not at task level
- other places are using
group.hana[0] - other places are using a combination like:
hosts: hana
vars:
is_primary: "{{ ansible_play_hosts[0] == inventory_hostname }}"
Let's keep it like this here but revisit it everywhere in all files.
mpagot
reviewed
Sep 6, 2024
| gcp_cluster_ip: ${hana-vip} | ||
| prefix: ${name_prefix} | ||
| project: ${gcp_project} | ||
| primary_zone: ${gcp_primary_zone} |
Collaborator
There was a problem hiding this comment.
Similar to the other comment, we can think about moving them to hosts>>hana section of the playbook
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables GCP native fencing, by passing the required variables from terraform to ansible and adding the gcp-specific stonith commands for ansible.
Verification Run
GCP
Native fencing
SBD
GCP SBD: http://openqaworker15.qa.suse.cz/tests/296342
AWS
AWS Native: http://openqaworker15.qa.suse.cz/tests/296341
AZURE
AZURE MSI: http://openqaworker15.qa.suse.cz/tests/296343