Local SAS token generation as normal user #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not run the sas token local generation as root. This prevent tools like az not to be found when running the deployment as normal user.
mpagot
force-pushed
the
qesap_sas_no_sudo_1
branch
from
69bcf99 to
3da7130
Compare
mpagot
commented
Sep 27, 2024
|
|
||
| - name: Download HANA media without SAS token |
There was a problem hiding this comment.
We probably no more need to support a token-less way to download the binary. On top of this there's no more way to reach this code after #264
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not run the SAS token local generation as root. This prevents tools like az not to be found when running the deployment as normal user.
Related ticket: https://jira.suse.com/browse/TEAM-9540
Verification