Qesap log ansible filename #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reorganize the internal implementation of how the list of ansible command is composed by the glue script. This commit does not have any behavioral changes.
Improve the way the log filename is calculated from the ansible playbook name. Name is no more detected within the command at fixed position but by parsing each element of the command and detecting playbook filename by the path. This new approach allow further change in the ansible-playbook command composition. This commit also restrict the dump to file only at ansible-playbook execution, leaving out the first ansible command.
mpagot
force-pushed
the
qesap_log_ansible_filename
branch
from
572bad7
to
1c11d49
Compare
jankohoutek
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorganize the internal implementation of how the list of Ansible
command is composed by the glue script. This first commit does not result in any behavioral changes.
Improve the way the log filename is calculated from the Ansible playbook
name. Name is no more detected within the command at fixed position but
by parsing each element of the command and detecting playbook filename
by the path. This new approach allows further change in the
ansible-playbook command composition. This commit also restrict the dump
to file only at ansible-playbook execution, leaving out the first
Ansible command.
Preliminary PR to fix a limitation in #234
This PR is needed now as preliminary task for TEAM-9713, as adding the folder creation command in the glue script result in an exception at the point the glue script try to calculate the log filename for the mkdir command (that does not need to record any log).
Related ticket: TEAM-9713
Verifications:
qesap deployment
Azure
sle-15-SP6-Qesap-Azure-Byos-x86_64-BuildLATEST_AZURE_SLE15_6_BYOS-qesap_azure_saptune_test -> http://openqaworker15.qa.suse.cz/tests/299398 🟢
sle-15-SP5-Qesap-Azure-Byos-x86_64-BuildLATEST_AZURE_SLE15_5_BYOS-qesap_azure_ansible_roles_test -> http://openqaworker15.qa.suse.cz/tests/299400
AWS
GCP
HanaSR
sle-15-SP6-HanaSr-Aws-Byos-x86_64-Build15-SP6_2024-10-08T02:03:26Z-hanasr_aws_test_fencing_sbd_stop_kill ec2_r4.8xlarge -> http://openqaworker15.qa.suse.cz/tests/299402
sle-15-SP6-HanaSr-Azure-Byos-x86_64-Build15-SP6_2024-10-08T02:03:26Z-hanasr_azure_test_saptune_msi az_Standard_E4s_v3 -> http://openqaworker15.qa.suse.cz/tests/299403