Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync of resource names #284

Closed
wants to merge 3 commits into from
Closed

Sync of resource names #284

wants to merge 3 commits into from

Conversation

jankohoutek
Copy link
Contributor

@jankohoutek jankohoutek commented Oct 10, 2024 •
edited
Loading

@jankohoutek jankohoutek mentioned this pull request Oct 15, 2024
Merged
alvarocarvajald
alvarocarvajald approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@alvarocarvajald alvarocarvajald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mpagot
mpagot approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@mpagot mpagot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, code on this side is fine.
But we need to agree how to merge it.

@jankohoutek jankohoutek marked this pull request as ready for review October 16, 2024 07:50
@jankohoutek jankohoutek deleted the sync_of_resource_names branch October 16, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpagot mpagot mpagot approved these changes

@alvarocarvajald alvarocarvajald alvarocarvajald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jankohoutek @alvarocarvajald @mpagot