Sidepanel preview (rebased on master) #258
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vítor Avelino <[email protected]>
- Issue 1 (slightly unrelated) - app service getspace action used space entity without an org - Issue 2 - app entity validation found it was missing the space - validation process fetched space with custom action - custom action did not contain schema key to use space with org schema - org was not stored correctly in store (contained in space rather than seperatly) - Still to do - Fix for issue 2 would need to be expanded to ALL schema's with inline entities - These new schemas would need to be added to their entities - All usages would have to provide the overriding schemaKey
This reverts commit 0a16203284cc0b42d172972047f5d08cddfecc99.
- Issue 1 (slightly unrelated)
- app service getspace action used space schema without an org
- Issue 2
- app entity validation found it was missing the space
- validation process fetched space with custom action
- custom action did not contain schema key linked to space schema with org
- this lead to org being not stored correctly in store (contained in space rather than seperatly)
- Simple fix (see 0a16203284c for harder)
- When normalizing prioritise the action's schema over attempting
to fetch via entity catalogue + schemaKey
(avoids A LOT of plumbing)
Signed-off-by: Vítor Avelino <[email protected]>
Signed-off-by: Vítor Avelino <[email protected]>
- Issue 1 (slightly unrelated) - app service getspace action used space entity without an org - Issue 2 - app entity validation found it was missing the space - validation process fetched space with custom action - custom action did not contain schema key to use space with org schema - org was not stored correctly in store (contained in space rather than seperatly) - Still to do - Fix for issue 2 would need to be expanded to ALL schema's with inline entities - These new schemas would need to be added to their entities - All usages would have to provide the overriding schemaKey
This reverts commit 0a16203284cc0b42d172972047f5d08cddfecc99.
- Issue 1 (slightly unrelated)
- app service getspace action used space schema without an org
- Issue 2
- app entity validation found it was missing the space
- validation process fetched space with custom action
- custom action did not contain schema key linked to space schema with org
- this lead to org being not stored correctly in store (contained in space rather than seperatly)
- Simple fix (see 0a16203284c for harder)
- When normalizing prioritise the action's schema over attempting
to fetch via entity catalogue + schemaKey
(avoids A LOT of plumbing)
Signed-off-by: Vítor Avelino <[email protected]>
Signed-off-by: Vítor Avelino <[email protected]>
Signed-off-by: Vítor Avelino <[email protected]>
Signed-off-by: Vítor Avelino <[email protected]>
Signed-off-by: Vítor Avelino <[email protected]>
Signed-off-by: Vítor Avelino <[email protected]>
Signed-off-by: Vítor Avelino <[email protected]>
Signed-off-by: Vítor Avelino <[email protected]>
- Issue 1 (slightly unrelated) - app service getspace action used space entity without an org - Issue 2 - app entity validation found it was missing the space - validation process fetched space with custom action - custom action did not contain schema key to use space with org schema - org was not stored correctly in store (contained in space rather than seperatly) - Still to do - Fix for issue 2 would need to be expanded to ALL schema's with inline entities - These new schemas would need to be added to their entities - All usages would have to provide the overriding schemaKey
This reverts commit 0a16203284cc0b42d172972047f5d08cddfecc99.
- Issue 1 (slightly unrelated)
- app service getspace action used space schema without an org
- Issue 2
- app entity validation found it was missing the space
- validation process fetched space with custom action
- custom action did not contain schema key linked to space schema with org
- this lead to org being not stored correctly in store (contained in space rather than seperatly)
- Simple fix (see 0a16203284c for harder)
- When normalizing prioritise the action's schema over attempting
to fetch via entity catalogue + schemaKey
(avoids A LOT of plumbing)
Signed-off-by: Vítor Avelino <[email protected]>
Signed-off-by: Vítor Avelino <[email protected]>
Signed-off-by: Vítor Avelino <[email protected]>
Signed-off-by: Vítor Avelino <[email protected]>
Signed-off-by: Vítor Avelino <[email protected]>
Signed-off-by: Vítor Avelino <[email protected]>
Signed-off-by: Vítor Avelino <[email protected]>
Signed-off-by: Vítor Avelino <[email protected]>
Signed-off-by: Vítor Avelino <[email protected]>
Signed-off-by: Vítor Avelino <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.