Doc updates to install, migration, and after migration sections #268
Conversation
|
screenshots of the changes, I didn't follow exactly the text in the issues, happy to revisit if the requested approach is preferred |
|
@KeithMnemonic @m0rbo I don't appear to be able to add reviewers, please review when time permits |
|
note that the official docs will have SUSE styling, which is not present in the screenshots here |
jeremy-moffitt
force-pushed
the
doc_fixups
branch
from
1a7b66f to
e1110fe
Compare
|
|
|
The Installation Section 4, option 2 should install both packages: |
jeremy-moffitt
force-pushed
the
doc_fixups
branch
from
e1110fe to
6353ae5
Compare
|
|
doc/adoc/user_guide.adoc
Outdated
| After the install of the `SLES15-Migration` package, start the migration | ||
| by calling the following command: | ||
| using the install option by calling the following command: |
There was a problem hiding this comment.
what is "install option" this seems to be misworded?
There was a problem hiding this comment.
maybe "start the migration process by calling.."
There was a problem hiding this comment.
In my original issue, the text got mangled.
#267
It's supposed to point back to Section 4. "Install option 1" for run_migration.
or "Install option 2" for reboot.
i put a number sign 1 and it became a pointer to issue 1. not sure how to put a number sign.
Section 4. "Install option #1" for run_migration. or "Install option #2" for reboot.
There was a problem hiding this comment.
fixed in the latest version
jeremy-moffitt
force-pushed
the
doc_fixups
branch
from
6353ae5 to
03b4e47
Compare
doc/adoc/user_guide.adoc
Outdated
| [NOTE] | ||
| If the `suse-migration-sle15-activation` package was installed, | ||
| start the migration by a reboot of the system as follows: | ||
| If using the `reboot` method and install option was used, |
There was a problem hiding this comment.
this still seems odd "and install option was use"
There was a problem hiding this comment.
good catch, changed it to
If using the `reboot` method to start migration, reboot the system:
03b4e47 to
a985c62
Compare
|
@m0rbo any additional feedback or should we go ahead and merge these changes? |
LGTM! |
Addresses doc feedback from #267 , #266 , and #265