Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proxy retail test to qe update to automatically #1290

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

maximenoel8
Copy link
Contributor

@maximenoel8 maximenoel8 commented Aug 8, 2024

What does this PR change?

In the current SLE update pipeline, the retail proxy feature is not being executed, which means that bind and DHCP packages are not automatically tested. To eliminate the need for manual testing of a feature that is already validated in Build Validation, this PR introduces the option to run the retail proxy feature. Since we do not have a terminal or build clients available, the scope is limited to running features/build_validation/retail/proxy_traditional_branch_network.feature. The option will be disabled by default and should be enabled only when relevant packages are involved.

Ideas for Further Improvement

Deploying sle15sp4_terminal and sle15sp4_buildhost as additional clients could enhance testing for TFTP packages, potentially saving time. However, this would require changes to the infrastructure. @Bischoff, is there enough space on PRV to accommodate these two additional clients?

@maximenoel8 maximenoel8 requested a review from a team August 8, 2024 21:04
Copy link
Member

@srbarrios srbarrios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of covering a sub-set of Retail tests.

⚠️ Keep in mind that DNS/DHCP is installed and configured by salt formulas as part of the Proxy/RBS Host in 4.3 (at least if we don't use the containerized flavor of the RBS 4.3), while in 5.0, DNS/DHCP is installed and configured by terraform in a different external host, meaning it's out of the responsibilities of the product.
So, regarding this PR, we miss this part on terracumber_config/tf_files/SUSEManager-5.0-SLE-update.tf

module "dhcp-dns" {
  source             = "./modules/dhcp_dns"
  base_configuration = module.base_core.configuration
  name               = "dhcp-dns"
  image              = "opensuse155o"
  private_hosts = [
    module.proxy_containerized.configuration
  ]
  hypervisor = {
    host        = "riverworld.mgr.prv.suse.net"
    user        = "root"
    private_key = file("~/.ssh/id_rsa")
  }
}

@maximenoel8
Copy link
Contributor Author

I removed 5.0 for the retail scope.

@maximenoel8 maximenoel8 self-assigned this Aug 12, 2024
@maximenoel8 maximenoel8 requested a review from a team August 12, 2024 22:16
@Bischoff
Copy link
Contributor

I removed 5.0 for the retail scope.

Hmmm, if you enable the DHCP and DNS server, you could make it work on 5.0 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants