Test clean for resubmission pipeline #1292
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximenoel8
force-pushed
the
cleanup_pipeline
branch
2 times, most recently
from
07bae83
to
1834d45
Compare
maximenoel8
force-pushed
the
cleanup_pipeline
branch
from
2fed09e
to
18b49f5
Compare
| return output | ||
|
|
||
| except Exception as e: | ||
| return f"Exception: {str(e)}" |
There was a problem hiding this comment.
Double checking: do we want the following behavior ?
If we catch all Exceptions here, the script won't fail when one happens and I think stages such as
stage('Delete ssh know hosts') {
sh(script: "${api_program} --url ${params.manager_hostname} --mode delete_known_hosts")
}
will still be green, as we do not check the return of this function in main.
The same holds true for the check on stderr.
There was a problem hiding this comment.
Indeed that's an issue I already had and need to improve.
| logger.info(f"File {local_path} copied to {remote_path} on server {url}") | ||
| return "File copy successful" | ||
|
|
||
| except Exception as e: |
There was a problem hiding this comment.
Same observation on Exception catching.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR ?
This PR gives the possibility to automatically handle the tools resubmission in the context of a release testing using BV.
In this PR there are two parts :
New cleanup pipeline ( for now 4.3 NUE and PRV )
What does this pipeline
Create a pipeline able to clean the server artifacts created during a BV run.
This pipeline will also redeploy the current clients using the new terracumber functionalities to modify a main.tf file.
What does NOT this pipeline
Adding or removing clients from the current deployment.
Redeploying monitoring and proxy.
New python scripts
main.py
Organize the modules and arguments.
suse_manager_api.py
Call the API ( from controller ) to clean the server artifacts.
suse_manager_ssh.py
Unfortunately, we require a ssh connection to server to remove the know hosts because the clients are fresh deployment.
Could be manage directly in groovy step if we don't want to add this python script.
Testing
Currently tested for debugging BV 4.3 NUE and PRV
Pipeline url : https://ci.suse.de/view/Manager/view/Manager-4.3/job/manager-4.3-qe-build-validation-NUE-cleaning/
What is missing ?
Issues
Related to: