Kafka initial implementation #1416
Conversation
| . \ | ||
| "/home/appuser/venv/bin/activate" \ | ||
| && \ | ||
| pip \ |
There was a problem hiding this comment.
wondering if we could use a SUSE package rather than using pip
| -m \ | ||
| venv \ | ||
| "/home/appuser/venv" \ | ||
| && \ |
There was a problem hiding this comment.
can't we use several commands within RUN section?
if you want to bail out at first error, there are several solutions:
set -eat the beginningrc = <command1>
[ rc == 0 ] && rc = <command2>
...- or maybe that's just the default behaviour in a dockerfile ?
There was a problem hiding this comment.
I think we can split this into multiple RUN commands, if we want to.
It should also improve layers caching for Docker at the cost of a final image which is (probably) slightly bigger
RUN python3 -m venv /home/appuser/venv
RUN . /home/appuser/venv/bin/activate \
&& pip install confluent_kafka==2.3.0 GitPython==3.1.43 requests==2.32.3
RUN git clone https://github.com/SUSE/susemanager-ci
| @@ -0,0 +1,62 @@ | |||
| # Kafka automation concept | |||
|
|
|||
| Messaging system to speed up business processes via services API. | |||
| @@ -0,0 +1,25 @@ | |||
|
|
|||
| logging.error(f'Request is too big, perhaps too many RRs to be accepted generated big JSON, run pipeline manually using generated custom_repositories.json in {os.getcwd()}') | ||
| return None | ||
|
|
||
| def pipeline_status(self): |
There was a problem hiding this comment.
Nitpicky, but maybe is worth changing this method name and signature to something like :
def pipeline_enabled(self) -> bool:| str(incident['incident']['incident_id']) | ||
| for incident in incidents['data'] | ||
| ) | ||
| subprocess.run( |
There was a problem hiding this comment.
Having set check=True, if the JSON generating scripts fails, for whatever reason, this function call will raise a subprocess.CalledProcessError
Maybe we should handle the possibility of a failure here, or where the generate_custom_repositories function is called, and at least log some useful info.
Initial implementation of https://github.com/SUSE/spacewalk/issues/24966.