Update terraform-libvirt-provider
#432
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjmateus
requested review from
Bischoff,
juliogonzalez,
ktsamis and
srbarrios
srbarrios
approved these changes
Jan 13, 2022
|
Fine, but it doesn't seems to include the build validation 4.3 tf, check if it needs some care too please. |
srbarrios
force-pushed
the
master
branch
24 times, most recently
from
bd9faef
to
816f63a
Compare
srbarrios
force-pushed
the
master
branch
10 times, most recently
from
98bd916
to
aefe924
Compare
|
This PR needs a rebase, an update for libvirt 0.6.14 and the 4.3 files have to be adjusted, too as Oscar mentioned above. |
rjmateus
force-pushed
the
terraform_libvirt_0_6_12
branch
2 times, most recently
from
436155d
to
6cf27ca
Compare
Signed-off-by: Ricardo Mateus <[email protected]>
rjmateus
force-pushed
the
terraform_libvirt_0_6_12
branch
from
6cf27ca
to
8f59d96
Compare
|
@nodeg @srbarrios this PR is ready to merge. If you agree I propose to merge it on monday, so we can have time to update all CI and have a closer look on them |
nodeg
changed the title
|
@rjmateus We discussed this in QE, let's wait for the submission of 4.3.1 to be done first (not released, just submitted), same with the uyuni submission and then we can merge this. |
|
Let's merge on Monday. |
nodeg
changed the title
terraform-libvirt-provider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up PR of
terraform-libvirt-provideruyuni-project/sumaform#1023Do not merge until the above PR got merged.
This PR will update all jobs to use the latest version of terraform libvirt provider version.