Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK: Enforce size limits on provided telemetry #10

Open
rtamalin opened this issue Jun 4, 2024 · 2 comments
Open

SDK: Enforce size limits on provided telemetry #10

rtamalin opened this issue Jun 4, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers SDK

Comments

@rtamalin
Copy link
Collaborator

rtamalin commented Jun 4, 2024

When a provider generates telemetry we should enforce a limit on the size of telemetry data that is provided, failing with an appropriate error.

We should also provide a mechanism that can be used by telemetry providers to determine the size limit, e.g. GetTelemetryDataLimits().

@gbuenodevsuse
Copy link
Collaborator

gbuenodevsuse commented Jun 21, 2024

Note:
Check payload size before compressing it for data storage (check #comment)
This will demand additional checks forward when retrieving telemetry data for over the wire transactions.

@gbuenodevsuse
Copy link
Collaborator

Issue reopened to further improve on compression.
See #comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers SDK
Projects
None yet
Development

No branches or pull requests

2 participants