Merged
Conversation
mbelur
previously requested changes
Jul 1, 2024
rtamalin
requested changes
Jul 8, 2024
Collaborator
rtamalin
left a comment
rtamalin
left a comment
There was a problem hiding this comment.
This PR should focus on the basic plumbing for enforcing the size limits for telemetry data item submissions.
The changes associated with the compression of the telemetry data items at rest in the client data store should be moved to a new PR, independent of this PR.
gbuenodevsuse
force-pushed
the
enforce_size_limits
branch
from
256f5a6 to
29027da
Compare
rtamalin
requested changes
Jul 9, 2024
Collaborator
rtamalin
left a comment
rtamalin
left a comment
There was a problem hiding this comment.
The code is generally good, just requesting a restructuring of where some of the code is placed.
rtamalin
reviewed
Jul 9, 2024
rtamalin
reviewed
Jul 9, 2024
Co-authored-by: Fergal Mc Carthy <fmccarthy@suse.com>
rtamalin
reviewed
Jul 10, 2024
rtamalin
reviewed
Jul 10, 2024
rtamalin
dismissed
mbelur’s stale review
Requested changes have been addressed but Meera is not around to re-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #10