Finish switching from log to slog for telemetry client #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also converts log.Fatal() calls to slog.Error() followed by return in many cases, especially those within the internal packages of the telemetry client library. Added missing checks for errors when decompressing data for item rows. Defined named return values for some of the datastore methods to simplify error handling and return statements. Minor other code cleanups. Closes: #15
gbuenodevsuse
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also converts log.Fatal() calls to slog.Error() followed by return in many cases, especially those within the internal packages of the telemetry client library.
Added missing checks for errors when decompressing data for item rows.
Defined named return values for some of the datastore methods to simplify error handling and return statements.
Minor other code cleanups.
Closes: #15