Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return complete object on scan read (AngleInDegrees) timeout #11

Open
wants to merge 26 commits into
base: master
Choose a base branch
from

Conversation

brannonvann
Copy link

It was returning incorrect structure upon timeout or no data available when reading scan (AngleInDegrees). This caused an error in the neato_node.

Traceback (most recent call last):
  File "/home/ubuntu/catkin_ws/src/intro_to_ros/bv80bot/neato_robot/neato_node/nodes/neato.py", line 209, in <module>
    robot.spin()
  File "/home/ubuntu/catkin_ws/src/intro_to_ros/bv80bot/neato_robot/neato_node/nodes/neato.py", line 119, in spin
    scan.ranges, scan.intensities = self.robot.getScanRanges()
ValueError: need more than 0 values to unpack

I experienced this on 2 different model Neatos. If I slowed the reading of the data I never experienced this problem and previously on a slower raspberry pi I did not notice this issue. I assume I'm seeing it now because the raspberry pi is processing faster than the neato can respond but I'm really not sure. The fix included in my commit resolves the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant