Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added alt tags to img elements #1026

Merged
merged 2 commits into from
Mar 2, 2025
Merged

Conversation

mscherotter
Copy link
Contributor

@mscherotter mscherotter commented Mar 1, 2025

PR description

Added alt text to images in UI to make it more accessible.

Checklist

Note that we require UI tests to ensure that the added feature will not be
nixed by some future fix and that there is at least some test-as-documentation
to indicate how the fix or enhancement is expected to behave.

  • [NA] - Added Cypress UI tests
  • [X ] - Ran npm test, ensuring linting passes and that Cypress UI tests keep
    coverage to at least the same percent (reflected in the coverage badge
    that should be updated after the tests run)
  • [NA ] - Added any user documentation. Though not required, this can be a big
    help both for future users and for the PR reviewer.

Summary by Sourcery

Enhancements:

  • Add alt text to img elements for better accessibility.

Copy link

sourcery-ai bot commented Mar 1, 2025

Reviewer's Guide by Sourcery

This pull request adds alt attributes to img elements in sePalette.js, seZoom.js, and seMenu.js to improve accessibility. The alt attributes provide alternative text for the images, which is important for users who are visually impaired or who are using screen readers.

Updated class diagram for SeZoom

classDiagram
  class SeZoom {
    +constructor()
    +connectedCallback()
    +disconnectedCallback()
    +updateZoom()
  }
  note for SeZoom "Added alt attribute to img element"
Loading

Updated class diagram for SeMenu

classDiagram
  class SeMenu {
    +constructor()
    +connectedCallback()
    +disconnectedCallback()
    +attributeChangedCallback(name, oldValue, newValue)
  }
  note for SeMenu "Added alt attribute to img element"
Loading

File-Level Changes

Change Details Files
Added alt attribute to the 'No color' image in sePalette.js to improve accessibility.
  • Added alt='No color' to the img element.
src/editor/components/sePalette.js
Added alt attribute to the zoom dropdown arrow image in seZoom.js to improve accessibility.
  • Added alt='Zoom dropdown' to the img element.
src/editor/components/seZoom.js
Added alt attribute to the logo image in seMenu.js to improve accessibility.
  • Added alt='logo' to the img element.
src/editor/components/seMenu.js

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mscherotter - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider using a more descriptive alt text than just 'logo'.
  • It might be helpful to extract the image creation logic into a separate function for better readability.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@jfhenon jfhenon merged commit 5ad039a into SVG-Edit:master Mar 2, 2025
5 checks passed
@mscherotter mscherotter deleted the img-alt-tags branch March 2, 2025 14:52
@mscherotter
Copy link
Contributor Author

@jfhenon Thanks for approving the PR. What is your schedule on updating the NPM module from master?

@jfhenon
Copy link
Collaborator

jfhenon commented Mar 2, 2025

I can do it this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants