-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed issue in EditorStartup.init() where $qq will not work if the editor is in a Web Component #1028
base: master
Are you sure you want to change the base?
Conversation
…ate label id issue reported in browser.
…onent. $qq will not find the .svg_editor, but this.$container will.
Reviewer's Guide by SourceryThis pull request addresses an issue where the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mscherotter - I've reviewed your changes - here's some feedback:
Overall Comments:
- Good job adding
alt
attributes to theimg
elements. - Consider using
const
instead oflet
for variables that are not reassigned after initialization.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to check linter issue
PR description
in EditorStartup init(),
this.$svgEditor = $qq('.svg_editor')
will return undefined if the editor is in a web component, Changing the line to
this.$svgEditor = this.$container.querySelector('.svg_editor')
will make the code work whether it is in a web component or not.
Checklist
Note that we require UI tests to ensure that the added feature will not be
nixed by some future fix and that there is at least some test-as-documentation
to indicate how the fix or enhancement is expected to behave.
npm test
, ensuring linting passes and that Cypress UI tests keepcoverage to at least the same percent (reflected in the coverage badge
that should be updated after the tests run)
help both for future users and for the PR reviewer.