Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/299 implement dark mode #314

Merged
merged 27 commits into from
Dec 25, 2023
Merged

Conversation

dbaslan
Copy link
Member

@dbaslan dbaslan commented Dec 20, 2023

This branch implements dark mode to the web app, in line with our stretch goal. 😎 Please let me know if I've missed any text or buttons, otherwise awaiting approval. The implementation is a bit rudimentary, all it does is darken the background image and the header color, and turn the headers and text white where necessary. It does not make use of Material UI's built-in dark mode, and I had to use inline CSS on a bunch of elements to get it done. It would be too chaotic otherwise. See #299

@dbaslan dbaslan added enhancement New feature or request frontend Related to frontend labels Dec 20, 2023
@dbaslan dbaslan added this to the Final Milestone milestone Dec 20, 2023
@dbaslan dbaslan requested review from a team December 20, 2023 17:11
@dbaslan dbaslan self-assigned this Dec 20, 2023
@dbaslan dbaslan mentioned this pull request Dec 20, 2023
@dbaslan
Copy link
Member Author

dbaslan commented Dec 20, 2023

Here are some screenshots:

Ekran görüntüsü 2023-12-20 200444

Ekran görüntüsü 2023-12-20 200422

@ckertam
Copy link
Collaborator

ckertam commented Dec 20, 2023

I need to test it more after I test it I will make my comment

Copy link
Member

@sadikkuzu sadikkuzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some comments and tiny little change-requests.
Thanks in advance.

backend/frontend/src/App.js Outdated Show resolved Hide resolved
backend/frontend/src/App.js Outdated Show resolved Hide resolved
backend/frontend/src/App.js Outdated Show resolved Hide resolved
backend/frontend/src/App.js Outdated Show resolved Hide resolved
backend/frontend/src/App.js Show resolved Hide resolved
@dbaslan dbaslan requested a review from sadikkuzu December 21, 2023 06:16
@sadikkuzu sadikkuzu requested a review from ckertam December 21, 2023 06:53
Copy link
Member

@sadikkuzu sadikkuzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dark Mode button:

I think (255,255,255) button-label-color is better than (0,0,0)
wdyt @dbaslan ?

before:
before

after:
after

Copy link
Member

@sadikkuzu sadikkuzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previous/Next buttons

I cannot see button labels in dark mode:

light:
light

dark:
dark

@dbaslan dbaslan requested review from sadikkuzu and a team December 22, 2023 20:30
@dbaslan
Copy link
Member Author

dbaslan commented Dec 22, 2023

Tried a bunch of solutions for the buttons, nothing worked. In the end I made the buttons disappear when disabled (i.e. when there is no previous or next page). Changed the dark mode button text color as per @sadikkuzu's request and fixed some minor visibility issues as well.

Copy link
Member

@sadikkuzu sadikkuzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create Memory page (Include time):

  • Normal Date
  • Interval Date

create-memory

Copy link
Member

@sadikkuzu sadikkuzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create Memory page (location alias):

location-alias

text-selected-version

@sadikkuzu
Copy link
Member

Tried a bunch of solutions for the buttons, nothing worked. In the end I made the buttons disappear when disabled (i.e. when there is no previous or next page). Changed the dark mode button text color as per @sadikkuzu's request and fixed some minor visibility issues as well.

Cool solution 👍🏼

next

previous

@dbaslan dbaslan requested a review from sadikkuzu December 23, 2023 10:11
@dbaslan
Copy link
Member Author

dbaslan commented Dec 23, 2023

Done and done @sadikkuzu 👍

Copy link
Collaborator

@ckertam ckertam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It was our dream I guess 😅

Copy link
Member

@sadikkuzu sadikkuzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfecto 👌🏼

@dbaslan dbaslan merged commit 0256a41 into dev Dec 25, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend Related to frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants