-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/299 implement dark mode #314
Conversation
I need to test it more after I test it I will make my comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some comments and tiny little change-requests.
Thanks in advance.
Co-authored-by: SADIK KUZU <[email protected]>
Co-authored-by: SADIK KUZU <[email protected]>
Co-authored-by: SADIK KUZU <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dark Mode button:
I think (255,255,255) button-label-color is better than (0,0,0)
wdyt @dbaslan ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried a bunch of solutions for the buttons, nothing worked. In the end I made the buttons disappear when disabled (i.e. when there is no previous or next page). Changed the dark mode button text color as per @sadikkuzu's request and fixed some minor visibility issues as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool solution 👍🏼 |
Done and done @sadikkuzu 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! It was our dream I guess 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfecto 👌🏼
This branch implements dark mode to the web app, in line with our stretch goal. 😎 Please let me know if I've missed any text or buttons, otherwise awaiting approval. The implementation is a bit rudimentary, all it does is darken the background image and the header color, and turn the headers and text white where necessary. It does not make use of Material UI's built-in dark mode, and I had to use inline CSS on a bunch of elements to get it done. It would be too chaotic otherwise. See #299