Fix broken prompt_reset_on_temperature#604
Merged
nguyendc-hub merged 7 commits intoSYSTRAN:masterfrom Dec 13, 2023
Purfview:patch-2
Merged
Fix broken prompt_reset_on_temperature#604nguyendc-hub merged 7 commits intoSYSTRAN:masterfrom Purfview:patch-2
nguyendc-hub merged 7 commits intoSYSTRAN:masterfrom
Purfview:patch-2
Conversation
nguyendc-hub
approved these changes
Dec 13, 2023
|
Thanks @Purfview for your PR. |
metame-none
pushed a commit
to metame-ai/faster-distil-whisper
that referenced
this pull request
Jan 2, 2024
* Fix broken prompt_reset_on_temperature Fixing: SYSTRAN#603 Broken because `generate_with_fallback()` doesn't return final temperature. Regression since PR356 -> SYSTRAN#356
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing: #603
Fixes broken prompt_reset_on_temperature functionality.
Broken because
generate_with_fallback()doesn't return final temperature.Regression since PR356 -> #356