Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add all new requested features #119

Merged
merged 3 commits into from
Jul 24, 2024
Merged

✨ Add all new requested features #119

merged 3 commits into from
Jul 24, 2024

Conversation

lvenier
Copy link
Contributor

@lvenier lvenier commented Jul 24, 2024

This PR includes all the foloowing issues :
#115
#116
#117
#118

No regression is foreseen and has been tested. But full test can be made when the plugin with the following container entity update :

  • cap_add : array of enum string nullable and and single enum string "NET_ADMIN" for now
  • cap_drop: array of enum string nullable and and single enum string "CHOWN" for now
  • pid_mode : a string
  • extra_hosts: array of strings
  • devices: it has the same format as binds and mounts. source and volume are used for now and it is defaulted to rw in the agent. To timprove in future release

Also UI has been updated with :

  • Renaming Volume to Storage in Container view
  • Adding Device and type in list storage list
  • Adding Extras tab ins container to add pidmode and extrahost
  • Adding Capabilities tab for capdrop and capextra

Tested with no regression in Netbox v4

@lvenier lvenier requested a review from linkdd July 24, 2024 07:37
@lvenier lvenier self-assigned this Jul 24, 2024
@linkdd linkdd merged commit 23c7c25 into main Jul 24, 2024
1 check passed
@linkdd linkdd deleted the new_all_features branch July 24, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants