Add native Windows support - #4
Open
Gunbrad wants to merge 1 commit into
Open
Conversation
Add Windows launchers, AppData-based user paths, and CompShare askpass integration for Windows OpenSSH. Preserve macOS/Linux behavior and cover both path styles with cross-platform tests and documentation.
There was a problem hiding this comment.
🟡 Changes recommended
Some Windows-specific failure modes still produce confusing behavior (askpass override existence validation and Node 20+ enforcement in .cmd launchers), and the updated install docs risk regressing macOS/Linux.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR adds native Windows support for the MiniMax H3 Cloud Codex plugin by introducing Windows launchers, Windows-appropriate user data/config/state path resolution, and Windows-compatible OpenSSH/askpass handling, while keeping existing macOS/Linux behavior intact.
Changes:
- Add Windows
.cmdlaunchers for onboarding/provisioning/generation and enforce platform-correct line endings via.gitattributes. - Implement Windows-aware path resolution (
APPDATA/LOCALAPPDATA) and update SSH tunnel handling to support Windows OpenSSH + CompShare askpass. - Update docs/skill instructions for Windows prerequisites and bump plugin version to
0.2.0with additional test coverage.
File summaries
| File | Description |
|---|---|
| README.md | Document Windows prerequisites, paths, and launcher usage. |
| plugins/minimax-h3-cloud/skills/minimax-h3-video/SKILL.md | Update skill guidance to use platform-specific entrypoints. |
| plugins/minimax-h3-cloud/scripts/h3-provision.cmd | Add Windows provisioning launcher wrapper. |
| plugins/minimax-h3-cloud/scripts/h3-onboard.cmd | Add Windows onboarding launcher wrapper. |
| plugins/minimax-h3-cloud/scripts/h3-cloud.cmd | Add Windows generation/status launcher wrapper. |
| plugins/minimax-h3-cloud/runtime/test/user-paths.test.mjs | Add tests for Windows and POSIX user path resolution. |
| plugins/minimax-h3-cloud/runtime/test/ssh-tunnel.test.mjs | Add tests for Windows SSH parsing/defaults and askpass behavior. |
| plugins/minimax-h3-cloud/runtime/test/config-store.test.mjs | Add atomic config update test coverage. |
| plugins/minimax-h3-cloud/runtime/test/compshare-cli.test.mjs | Add tests for executable overrides and Windows BOM JSON handling. |
| plugins/minimax-h3-cloud/runtime/src/user-paths.mjs | Implement Windows-aware config/data/state directory resolution. |
| plugins/minimax-h3-cloud/runtime/src/ssh-tunnel.mjs | Improve SSH login parsing, add askpass context, and support Windows OpenSSH defaults. |
| plugins/minimax-h3-cloud/runtime/src/executable-paths.mjs | Add helpers to resolve executables on PATH across platforms. |
| plugins/minimax-h3-cloud/runtime/src/compshare-cli.mjs | Add executable/askpass resolution and improve error handling + BOM parsing. |
| plugins/minimax-h3-cloud/.codex-plugin/plugin.json | Bump version to 0.2.0 and add Windows metadata. |
| .gitattributes | Enforce consistent line endings (CRLF for .cmd, LF elsewhere). |
Review details
- Files reviewed: 15/15 changed files
- Comments generated: 5
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+56
to
+60
| const override = environmentValue( | ||
| env, | ||
| "MINIMAX_H3_SSH_ASKPASS_PATH", | ||
| )?.trim(); | ||
| if (override) return override; |
Comment on lines
+12
to
+16
| where node.exe >nul 2>nul | ||
| if errorlevel 1 ( | ||
| echo Node.js 20 or newer is required and must be available on PATH. 1>&2 | ||
| exit /b 1 | ||
| ) |
Comment on lines
+12
to
+16
| where node.exe >nul 2>nul | ||
| if errorlevel 1 ( | ||
| echo Node.js 20 or newer is required and must be available on PATH. 1>&2 | ||
| exit /b 1 | ||
| ) |
Comment on lines
+12
to
+16
| where node.exe >nul 2>nul | ||
| if errorlevel 1 ( | ||
| echo Node.js 20 or newer is required and must be available on PATH. 1>&2 | ||
| exit /b 1 | ||
| ) |
Comment on lines
+32
to
+33
| python -m pip install --upgrade compshare-cli | ||
| compshare --version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
No cloud GPU resources were created and no billable generation was started during validation.