Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: add category specific fields #63

Merged
merged 3 commits into from
Sep 14, 2024
Merged

Conversation

Synar
Copy link
Contributor

@Synar Synar commented Sep 14, 2024

No description provided.

Copy link
Member

@ElysaSrc ElysaSrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM. Nothing to say on the logic part, various comments on the style.

backend/src/models/comment.rs Outdated Show resolved Hide resolved
@@ -187,7 +195,7 @@ impl AdminComment {
RETURNING *
)
SELECT i.id, i.entity_id, i.author, i.text, i.data, i.created_at, i.updated_at, i.moderated, i.version,
e.display_name as entity_display_name, e.category_id
e.display_name as entity_display_name, e.category_id as entity_category_id
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same.

backend/src/models/comment.rs Outdated Show resolved Hide resolved
backend/src/models/comment.rs Outdated Show resolved Hide resolved
frontend/components/CommentsDisplayer.vue Show resolved Hide resolved
frontend/pages/admin/families/[id]/entities.vue Outdated Show resolved Hide resolved
Copy link
Member

@ElysaSrc ElysaSrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You didn't change regenerate the sqlx cache file. Go on the backend folder and run cargo sqlx prepare.

@ElysaSrc ElysaSrc merged commit ffbe017 into main Sep 14, 2024
1 check passed
@ElysaSrc ElysaSrc deleted the al/category-specific-fields branch September 14, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants