This repository has been archived by the owner on Aug 5, 2020. It is now read-only.
Feature/w3c parser tests #65
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove getRealValueBasedOnDatatype from NodeUtils
Add Parser interface again, improve test setup and add new method for string parsing to interface
…rld was not found I guess if that function is not available, Redland was not installed. So if you keep check for that function, you should know when its available or not.
- add line between <?php and namespace declaration - " to ' - ! to false === - add some comments with further information - remove empty lines
It was assertTrue the result of the function, but it does not return anything.
Given $graph must be of type NamedNode, not just Node. Reason is, that we want a graph which is represented by an URI, so we dont want Literals or AnyPattern given. Drop createGraph and dropGraph from all store implementations, because they basically call the query method. These 2 methods are now located in AbstractSparqlStore.php.
This commit also contains codesniffer fixes
Both HTTP and Virtuoso call statement related methods from AbstractSparqlStore instead of implementing their own. That means, much less code to maintain and better compatibility. AbstractSparqlStore: - Pimp getMatchingStatements by set filters in WHERE clause for s, p or o, which is a literal or URI. - Better graph handling in hasMatchingStatement Virtuoso: Removed sqlQuery function, because it is not needed anymore. It was before to get available graphs.
Fore more information: #6
That functions helps you to save code. It is useful in cases where you have all the meta information about a node (type, value, ...) but dont want to write that switch to create the right node type, especially if you want to use a NodeFactory too. Tests also added.
Is related to testSerializeIteratorToStreamAsNQuads test.
General: - add countTriples function to count triples of a certain graph ARC2: - add support for DELETE WHERE queries containing quads - add support for SELECT COUNT queries. ARC2 adapter will now handles such queries as every adapter too, not just returning the number but to create a SetResult instance ARC2Test: - Skip testQueryAddAndQueryStatementsDefaultGraph test, because ARC2 does not support write or read operations to the default graph AbstractTripleStoreTest: - remove markTestSkipped from testDeleteMultipleStatementsVariablePatterns. HttpTest: - mark test testQueryAddAndQueryStatementsDefaultGraph skipped, because we do not know if the endpoint supports write or read operations on the default graph StoreAbstractTest: - remove markTestSkipped from testDeleteMatchingStatementsQuadRecognition - fix a couple of tests (make it more precise, some restructuring) - remove markTestSkipped from testQueryDeleteMultipleStatementsVariablePatterns; improved that test overall
Because they were missed. Added EmptyResultImplTest.php with basic tests.
And add isEmptyResult and isValueResult to StatementSetResultImpl.php.
Replace assertIteratorContent by assertStatementIteratorEquals and assertResultEquals
|
Thanks @guitarmarx for your contribution! Info's
TODO for us
|
|
Maybe related to #56 |
|
Shit, i think i accidentally closed this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.