AG-1399 fix invalid ensg in url from hanging #1299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagely1
commented
Apr 16, 2024
src/app/features/genes/components/gene-details/gene-details.component.ts
Show resolved
Hide resolved
sagely1
commented
Apr 16, 2024
sagely1
commented
Apr 16, 2024
sagely1
commented
Apr 16, 2024
hallieswan
reviewed
Apr 17, 2024
src/app/features/genes/components/gene-details/gene-details.component.ts
Show resolved
Hide resolved
Comment on lines
72
to
76
| .subscribe((gene: Gene | null) => { | ||
| if (gene) { | ||
| this.gene = gene; | ||
| this.init(); | ||
| } |
There was a problem hiding this comment.
Should this component also handle a gene that doesn't exist? Looks like navigating to https://agora.adknowledgeportal.org/genes/ENSG55555555555/similar causes the same behavior as the route mentioned in the ticket.
There was a problem hiding this comment.
Good catch! The same fix applies from gene-details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When invalid ENSG were input into the URL, the app would show a loading screen and appeared to hang.