Skip to content

Commit

Permalink
Use "=" instead of IN
Browse files Browse the repository at this point in the history
The subquery should only return a single row so there is no need to
use IN. Using "=" avoids a situation where the planner can sidestep
the LIMIT in the subquery.
collectiveidea#169
  • Loading branch information
SaitoJP committed Jul 8, 2020
1 parent 337c09c commit a04412a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/delayed/backend/active_record.rb
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ def self.reserve_with_scope_using_optimized_postgres(ready_scope, worker, now)
# use 'FOR UPDATE' and we would have many locking conflicts
quoted_name = connection.quote_table_name(table_name)
subquery = ready_scope.limit(1).lock(true).select("id").to_sql
sql = "UPDATE #{quoted_name} SET locked_at = ?, locked_by = ? WHERE id IN (#{subquery}) RETURNING *"
sql = "UPDATE #{quoted_name} SET locked_at = ?, locked_by = ? WHERE id = (#{subquery}) RETURNING *"
reserved = find_by_sql([sql, now, worker.name])
reserved[0]
end
Expand Down

0 comments on commit a04412a

Please sign in to comment.