feat(PlayerController): Refactor SearchAccount API methods

- Simplified the implementation of the SearchAccount method in PlayerController.
- Replaced conditional statement with a ternary operator for better readability.
- Added 'await' keyword to the GetUserAsync method in UserService to ensure asynchronous execution.
- Simplified the implementation of the ListPlayersAsync method in PlayerService.
- Replaced conditional statement with a ternary operator for better readability.
- Updated return type to AccountListingDTO[] instead of IEnumerable<AccountListingDTO>.

WowsKarma.Api/Controllers/PlayerController.cs

@@ -34,14 +34,10 @@ public PlayerController(PlayerService playerService)
 	/// <response code="200">Account listings for given search query</response>
 	/// <response code="204">No results found for given search query</response>
 	[HttpGet("search/{query}"), ProducesResponseType(typeof(IEnumerable<AccountListingDTO>), 200), ProducesResponseType(204)]
-	public async Task<IActionResult> SearchAccount([StringLength(100, MinimumLength = 3), RegularExpression(@"^[a-zA-Z0-9_]*$")] string query)
-	{
-		IEnumerable<AccountListingDTO> accounts = await _playerService.ListPlayersAsync(query);
-
-		return accounts is null
-			? NoContent()
-			: Ok(accounts);
-	}
+	public async Task<IActionResult> SearchAccount([StringLength(100, MinimumLength = 3), RegularExpression(@"^[a-zA-Z0-9_]*$")] string query) 
+		=> await _playerService.ListPlayersAsync(query) is { Length: not 0 } accounts
+			? Ok(accounts)
+			: NoContent();
 
 	/// <summary>
 	/// Fetches the player profile for a given Account ID.

WowsKarma.Api/Services/Authentication/UserService.cs

@@ -31,7 +31,7 @@ public UserService(AuthDbContext context, IHubContext<AuthHub, IAuthHubPush> hub
 	/// </summary>
 	/// <param name="id">The user's ID.</param>
 	/// <returns>The user, or <see langword="null"/> if not found.</returns>
-	public Task<User?> GetUserAsync(uint id) => _context.Users.Include(u => u.Roles).FirstOrDefaultAsync(u => u.Id == id);
+	public async Task<User?> GetUserAsync(uint id) => await _context.Users.Include(u => u.Roles).FirstOrDefaultAsync(u => u.Id == id);
 
 	/// <summary>
 	/// Gets a user's claims

WowsKarma.Api/Services/PlayerService.cs

@@ -138,14 +138,10 @@ public IEnumerable<AccountFullKarmaDTO> GetPlayersFullKarma(IEnumerable<uint> ac
 				.Where(p => accountIds.Contains(p.Id))
 				.Select(p => new AccountKarmaDTO(p.Id, p.SiteKarma)));
 
-	public async Task<IEnumerable<AccountListingDTO>> ListPlayersAsync(string search)
-	{
-		AccountListing[] result = (await _wgApi.ListPlayersAsync(search))?.Data?.ToArray();
-
-		return result is { Length: > 0 }
-			? result.Select(listing => listing.ToDto())
-			: null;
-	}
+	public async Task<AccountListingDTO[]> ListPlayersAsync(string search) 
+		=> (await _wgApi.ListPlayersAsync(search))?.Data?.ToArray() is { Length: not 0 } result
+			? result.Select(Conversions.ToDto).ToArray()
+			: [];
 
 	internal async Task<Player> UpdatePlayerClanStatusAsync(Player player, CancellationToken ct = default)
 	{