Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update downloader.h and downloader.c #955

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Conversation

rico33631
Copy link
Member

Description

This pull request introduces platform-independent handling for socket closure. It replaces the use of close() with the CLOSE_SOCKET() macro to ensure compatibility across both Windows and POSIX-based systems.

Related Issue

resolves issue #948

Proposed Changes

  1. Defined a macro CLOSE_SOCKET() in the downloader.h header file to abstract socket closing based on the platform:
  2. Replaced all instances of close() with CLOSE_SOCKET() in the source files to maintain cross-platform compatibility.

Checklist

  • I have tested these changes locally.
  • My code follows the project's coding style guidelines.
  • I have reviewed my own code to ensure quality.
  • Unnecessary comments were removed.

@BaseMax
Copy link
Member

BaseMax commented Jan 13, 2025

Many thanks

Please delete extra newlines:
image

@BaseMax BaseMax merged commit 72a0152 into SalamLang:main Jan 13, 2025
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants