Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecations; support geographic coordinates; add some type hinting/formatting #6

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

dluks
Copy link

@dluks dluks commented May 19, 2024

I've added some general updates to bring spacv a bit more into alignment with its dependencies, as well as added a few bugfixes and quality-of-life improvements.

  • Fixes cannot import name 'asPolygon' from 'shapely.geometry' #4 (deprecated shapely syntax)
  • Fixes deprecated numpy typing
  • Fixes error when zero buffer is provided (similar to Fix train excluded for zero buffer radius #5, and in fact I think I like their solution a bit better)
  • Adds support for geographic coordinates
  • Fixes semivariance indexing bug that prevented curve_fit from fitting
  • Adds some black formatting for consistency
  • Adds some type hinting
  • Fixes deprecated geopandas sjoin param usage
  • Only calculates autocorrelation ranges for a maximum of 30,000 points to prevent memory overflows for large datasets
  • Fixes pygeos install issue for python 3.12 by removing it from dependencies since pygeos was merged into Shapely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cannot import name 'asPolygon' from 'shapely.geometry'
1 participant