-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[93] New Docker command to generate DockerFiles of specified services #34
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Updated existing test and implemented e2e test for docker command |
Completed:
|
README.md for Docker Command Docker Command
Description Creates a docker service/container for given command.
Arguments
Options
Note: Docker command supports multiple services at a time. Services
How to include new docker services ?Stencil-cli
Schematics
Which files will be changed/updated?Tooling setup
Adhoc Setup
|
); | ||
const schematicOptions: SchematicOption[] = this.mapSchematicOptions(commandInputs); | ||
schematicOptions.push( | ||
new SchematicOption('language', 'ts'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why have we hardcoded to ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was already present with new command
It is the default language which is pushed if no language is given by the user
|
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: SamagraX-Stencil/stencil#135 (comment)
schematics link: SamagraX-Stencil/schematics#10
What is the new behavior?
stencil docker <services...>
where
<services>
= monitoring logging temporalDoes this PR introduce a breaking change?
Other information