[NUI] Remove NUI.Components not used for tv profile #6613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…allback Let we keep Idler callback list as membery of internal Application class, and allow to remove them during idler callback execute. Signed-off-by: Eunki, Hong <[email protected]>
…ImageUrl Since ImageUrl's reference should be hold on image visual, we should generate image visual synchronously, not on Processor time. + Minor code clean up applied Signed-off-by: Eunki, Hong <[email protected]>
Signed-off-by: Changgyu Choi <[email protected]>
Signed-off-by: Jiyun Yang <[email protected]>
* Do not convert Vector4 to Color when initializing static colors * Eventually, static colors should be created by r, g, b values by c# code, not getting from DALi * Preload static colors Signed-off-by: Jiyun Yang <[email protected]>
ControlState was implemented inefficently on the memory and the performance. This patch purposed to reduce inefficency by using bitflags on the state instead of string list. [https://github.sec.samsung.net/NUI/OneUIComponents/issues/15] long type bitmask will be represent each states, 1 1 1 1 1 O S D P F Normal : 0L Focused : 1L Pressed : 2L Disabled : 4L Selected : 8L Other : 16L and All : 31L This concept is based on VisualState of NUI2, https://github.sec.samsung.net/dotnet/nui2/blob/main/src/Tizen.NUI2.Components/Base/ViewState.cs but we had to modified few states to keep backward compatibility of NUI ControlState.
Reorganized entire project structure for improved clarity and maintainability. Introduced customizable interfaces for AI functionalities, allowing seamless integration of third-party modules. Optimized existing code base for increased efficiency and reduced redundancy. Co-authored-by: Angler <[email protected]>
Since transform data is kind of renderer property internally, we don't need to re-create them. Let we use UpdateProperty action for this case. Signed-off-by: Eunki, Hong <[email protected]>
- We MUST call ReleaseBuffer after call AcquireBuffer - We MUST call AcquireBUffer before call ReleaseBuffer If not, exception or deadlock will occured. Signed-off-by: Eunki, Hong <[email protected]>
Co-authored-by: Woochan Lee <[email protected]>
…tidl (Samsung#6536) * Add new methods to support new types in tidl Signed-off-by: pjh9216 <[email protected]> * Add attributes for internal APIs Signed-off-by: pjh9216 <[email protected]> * Use sizeof operator Signed-off-by: pjh9216 <[email protected]> --------- Signed-off-by: pjh9216 <[email protected]>
Introduce the value type of color, vector2 and shadow. They will replace existing reference types gradually. Signed-off-by: Jiyun Yang <[email protected]>
NUI Language version upgrade for 9.
Let we add 'using' mark for temerally used `PropertyValue`. Optimize PropertyMap.Add() API if it is prepared. It is knd of next-step. So current PR could be keep going on Signed-off-by: Eunki, Hong <[email protected]>
PivotPoint, AnchorPoint, Position
Signed-off-by: Jiyun Yang <[email protected]>
This also includes PropertyMap optimizations to prevent value type being conveted to reference type again. Signed-off-by: Jiyun Yang <[email protected]>
(1) Introduce the value type of ControlState. It replaces ControlState implementation. (2) Notify IsEnabled changed to control state outside of view. Signed-off-by: Jiyun Yang <[email protected]>
Signed-off-by: Seungho Baek <[email protected]>
Signed-off-by: Jiyun Yang <[email protected]>
Signed-off-by: Eunki, Hong <[email protected]>
Signed-off-by: Junseok Kim <[email protected]>
Signed-off-by: Jiyun Yang <[email protected]>
Signed-off-by: Jiyun Yang <[email protected]>
Signed-off-by: Jiyun Yang <[email protected]>
Signed-off-by: Jiyun Yang <[email protected]>
Signed-off-by: Seungho Baek <[email protected]>
- Artifact actions v3 will be closing down by Jan 30, 2025 - https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md Co-authored-by: shmin <[email protected]>
* Update CODEOWNERS * Update CODEOWNERS * Update CODEOWNERS * Update CODEOWNERS * Update CODEOWNERS * Update CODEOWNERS * Update CODEOWNERS * Update CODEOWNERS * Update CODEOWNERS * Update CODEOWNERS * Update CODEOWNERS * Update CODEOWNERS * Update CODEOWNERS * Update CODEOWNERS * Update CODEOWNERS
Let we allow to use FrameUpdateCallbackInterface could use UIVector2 and UIColor so we can reduce GC call at render thread. Require dali patch : https://review.tizen.org/gerrit/c/platform/core/uifw/dali-csharp-binder/+/318520 Signed-off-by: Eunki, Hong <[email protected]>
Previously, if a cell has multiple ColumnSpacing or RowSpacing with Stretch Expand, its column or row does not occupy Expand space if the column or row is empty. e.g. Child2 begins the beginning of the GridLayout without preserving the empty space for Row 1, Column 0. GridLayout Width 400. Child1 Row 0, Column 0, ColumnSpan 2, HorizontalStretch Expand Child2 Row 1, Column 1, ColumnSpan 1, HorizontalStretch None, Width 100 ------------------------------------- |||||||||||||||Child1|||||||||||||||| ------------------------------------- ||Child2|| | ------------------------------------- Now, it has been fixed to make the column or row occupy Expand space even though the column or row is empty. To do so, virtual edges for the column or row have Stretch Expand. It works the same way as CSS grid. e.g. Child2 begins after the empty space for Row 1, Column 0. ------------------------------------- |||||||||||||||Child1|||||||||||||||| ------------------------------------- | ||Child2|| | -------------------------------------
If an application does not use Layout, then View's variables used for Layout waste memory. To remove those wasted memory, those variables are moved to the new internal class LayoutExtraData and it is not allocated if Layout is not used. Signed-off-by: Jiyun Yang <[email protected]>
Add C# MarkUp Extension methods for View Properties. e.g) View myView = new ().Size(10f, 10f) .Position(10f, 10f) .Layout(new LienarLayout) .Padding(5f, 5f, 5f, 5f) .BackgroundColor(1f, 1f, 1f, 1f) Added Properties - Color - ImageShadow - Borderline - Opacity - Scale - Visibility - Sensitive - IsEnabled - ClippingMode - Layout - Focusable - FocusableChildren - FocusableInTouch - VoiceInteractionName - OffScreenRendering and few getters for UI struct types. - Color - BorderlineColor
EXaml is not used by app: 1) Remove EXaml in Tizen.NUI. 2) Remove testcases for EXaml in Tizen.NUI.Devel.Tests 3) Disable EXaml in XmlBuild.
dongsug-song
requested review from
Seoyeon2Kim,
taehyub,
jaehyun0cho,
everLEEst and
rabbitfor
as code owners
dongsug-song
force-pushed
the
DevelNUI
branch
from
c9eda11 to
772cc29
Compare
|
Hello, There was a diff and conflict between DevelNUI and main, causing difficulties in integrating NUI. Therefore, a hard reset was performed on DevelNUI. As a result, the pull requests (https://github.com/Samsung/TizenFX/pulls) in DevelNUI are now conflicting. To resolve this, you can go to the specific PR, where you will see an error indicating a conflict. You can then use the command line to resolve the conflict. I'm sorry for the inconvenience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
[NUI] Remove NUI.Components not used for tv profile
API Changes
Deprecated ACR will be raised