Flusing log uart during fault #6660
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When system fault is occured, The system is in the irq locking state, The logs that have not yet been output remain in the uart buffer and are not output. So, For debugging, it is necessary to flush the log uart buffer before outputting the fault log. For flushing transmit buffe, we need to know xmit buffer is empty or not. Therefore, Add to so that uart_xmitchars function returns amount sent. the return value is 0, xmit buffer is empty. Signed-off-by: eunwoo.nam <[email protected]>
ewoodev
force-pushed
the
WORK-250206_flush_log_uart
branch
6 times, most recently
from
4532208 to
4ed0553
Compare
…ault log. since, The system fault is occured, uart log is stil in the uart buffer and not printed. So, we can't see last log. Therefore, Add flusing log uart buffer when fault is occured. Signed-off-by: eunwoo.nam <[email protected]>
ewoodev
force-pushed
the
WORK-250206_flush_log_uart
branch
from
4ed0553 to
fef47cc
Compare
|
|
||
| /* To avoid duplicated calling up_flush_console(). */ | ||
| if (g_log_flush_running) { | ||
| return; |
There was a problem hiding this comment.
we should have leave_critical_section here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.