Skip to content

Conversation

@neel-samsung
Copy link
Contributor

No description provided.

This patch resolves the typo while using the API name
in the comment.

Signed-off-by: neel-samsung <[email protected]>
This patch adds comment which describes returned value and assumptions for
up_unblock_task() and up_block_task(). These APIs need to called under established
critical section.

Signed-off-by: neel-samsung <[email protected]>
@neel-samsung neel-samsung changed the title Fix comments Fix comments (Do not merge) [Under Review] Jul 24, 2025
@neel-samsung neel-samsung changed the title Fix comments (Do not merge) [Under Review] Fix comments [Under Review] Jul 24, 2025
Copy link
Contributor

@Sambhavi-1 Sambhavi-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr fixing comment description

/* Move any tasks in the ready-to-run list to the pending task list
* where they will not be available to run until the scheduler is
* unlocked and nxsched_merge_pending() is called.
* unlocked and sched_mergepending() is called.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected spelling mistakes and added more description.

Copy link
Contributor

@seokhun-eom24 seokhun-eom24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

seokhun-eom24 added a commit to seokhun-eom24/TizenRT that referenced this pull request Oct 20, 2025
This commit fixes function names from the 'nxsched_*' prefix to 'sched_*'.
And fix some typo errors and wrong wrapper function description.

- nxsched_process_timer -> sched_process_timer
- nxsched_timer_expiration -> sched_timer_expiration
- nxsched_merge_pending -> sched_mergepending
- sched_getaffinity is wrapper of sched_gettcb
- sched_setaffinity is wrapper of sched_setpriority

This changes are inspired by Samsung#6896

Signed-off-by: seokhun-eom <[email protected]>
sunghan-chang pushed a commit that referenced this pull request Oct 20, 2025
This commit fixes function names from the 'nxsched_*' prefix to 'sched_*'.
And fix some typo errors and wrong wrapper function description.

- nxsched_process_timer -> sched_process_timer
- nxsched_timer_expiration -> sched_timer_expiration
- nxsched_merge_pending -> sched_mergepending
- sched_getaffinity is wrapper of sched_gettcb
- sched_setaffinity is wrapper of sched_setpriority

This changes are inspired by #6896

Signed-off-by: seokhun-eom <[email protected]>
Copy link
Contributor

@samsung-singh samsung-singh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix comments in arch arm task and kernel sched lock module, this change is good to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants