-
Notifications
You must be signed in to change notification settings - Fork 618
Fix comments [Under Review] #6896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This patch resolves the typo while using the API name in the comment. Signed-off-by: neel-samsung <[email protected]>
This patch adds comment which describes returned value and assumptions for up_unblock_task() and up_block_task(). These APIs need to called under established critical section. Signed-off-by: neel-samsung <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pr fixing comment description
| /* Move any tasks in the ready-to-run list to the pending task list | ||
| * where they will not be available to run until the scheduler is | ||
| * unlocked and nxsched_merge_pending() is called. | ||
| * unlocked and sched_mergepending() is called. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected spelling mistakes and added more description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This commit fixes function names from the 'nxsched_*' prefix to 'sched_*'. And fix some typo errors and wrong wrapper function description. - nxsched_process_timer -> sched_process_timer - nxsched_timer_expiration -> sched_timer_expiration - nxsched_merge_pending -> sched_mergepending - sched_getaffinity is wrapper of sched_gettcb - sched_setaffinity is wrapper of sched_setpriority This changes are inspired by Samsung#6896 Signed-off-by: seokhun-eom <[email protected]>
This commit fixes function names from the 'nxsched_*' prefix to 'sched_*'. And fix some typo errors and wrong wrapper function description. - nxsched_process_timer -> sched_process_timer - nxsched_timer_expiration -> sched_timer_expiration - nxsched_merge_pending -> sched_mergepending - sched_getaffinity is wrapper of sched_gettcb - sched_setaffinity is wrapper of sched_setpriority This changes are inspired by #6896 Signed-off-by: seokhun-eom <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix comments in arch arm task and kernel sched lock module, this change is good to merge.
No description provided.