Handle LCD_ST7785_TYPEA(inverted) and LCD_ST7785_TYPEB(non_inverted) in power logic #6908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nverted) and LCD_ST7785_TYPEB(non_inverted) in power logic Add CONFIG_LCD_ST7785_TYPEA to existing power inversion condition(via OR) Add CONFIG_LCD_ST7785_TYPEB in non-inverted power path under existing elif
Taejun-Kwon
reviewed
Jul 29, 2025
| InterruptEn(lcdc_irq_info.num, lcdc_irq_info.priority); | ||
| } | ||
| #if defined(CONFIG_LCD_ST7701SN) | ||
| #if defined(CONFIG_LCD_ST7701SN) || defined(CONFIG_LCD_ST7785_TYPEA) |
There was a problem hiding this comment.
you should refer to my comment in your another PR, #6910 (comment)
so below style can be applied. we hide h/w from this code.
static void rtl8730e_control_backlight(float level)
{
...
pwmout_write(&g_rtl8730e_config_dev_s.pwm_led, level);
...
}
static int lcd_setpower(FAR struct lcd_dev_s *dev, int power)
{
FAR struct mipi_lcd_dev_s *priv = (FAR struct mipi_lcd_dev_s *)dev;
struct mipi_dsi_device *dsi = dev->dsi_dev;
...
dsi->lcd_setpower(priv->config, power);
...
}
static void st7785_lcd_setpower(struct mipi_lcd_config_s *config, int power)
{
float level = level/100.0
config->backlight(level);
}
static void st7701SN_lcd_setpower(struct mipi_lcd_config_s *config, int power)
float level = 1.0 - (level/100.0);
config->backlight(level);
}
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using config macros to perform backlight inversion because we are setting backlight to 0 before initialization. At this point we can not read the value of power_inversion, so the inversion logic must be decided statically using config macros.