-
Notifications
You must be signed in to change notification settings - Fork 618
kernel/binary_manager: Reduce stack size of binary manager to 3K #6951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Reduce stack size of binary manager to 3K. We measured the peak stack usage of binary manager based on some tests and got the below result. PID | STATUS | SIZE | PEAK_STACK | PEAK_HEAP | TIME | THREAD NAME ------|----------|----------|------------|------------|---------|------------ 13 | ACTIVE | 8168 | 928 | 8240 | 134687 | binary_manager
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The case when ELF loading enabled :
PID | STATUS | SIZE | PEAK_STACK | PEAK_HEAP | TIME | THREAD NAME
------|----------|----------|------------|------------|---------|------------
7 | ACTIVE | 8168 | 1068 | 8528 | 919090 | binary_manager
Even with ELF load (RAM load) enabled, the reduction looks fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stack size modification for the Binary manager task seems fine based on the test results mentioned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reduced stack size of binary manager to 3K in kernel binary manager module, this change is good to merge.
Reduce stack size of binary manager to 3K.
We measured the peak stack usage of binary manager based on some tests and got the below result.