Skip to content

Conversation

@jeongarmy
Copy link
Contributor

Reduce stack size of binary manager to 3K.

We measured the peak stack usage of binary manager based on some tests and got the below result.

PID STATUS SIZE PEAK_STACK PEAK_HEAP TIME THREAD NAME
13 ACTIVE 8168 928 8240 134687 binary_manager

Reduce stack size of binary manager to 3K.

We measured the peak stack usage of binary manager based on some tests and got the below result.
  PID |   STATUS |     SIZE | PEAK_STACK |  PEAK_HEAP |    TIME | THREAD NAME
------|----------|----------|------------|------------|---------|------------
   13 |   ACTIVE |     8168 |        928 |       8240 |  134687 | binary_manager
Copy link
Contributor

@seokhun-eom24 seokhun-eom24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@pcs1265 pcs1265 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@neel-samsung neel-samsung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge

Copy link
Member

@pcs1265 pcs1265 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The case when ELF loading enabled :

  PID |   STATUS |     SIZE | PEAK_STACK |  PEAK_HEAP |    TIME | THREAD NAME
------|----------|----------|------------|------------|---------|------------
    7 |   ACTIVE |     8168 |       1068 |       8528 |  919090 | binary_manager

Even with ELF load (RAM load) enabled, the reduction looks fine.

Copy link
Collaborator

@r-prabu r-prabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stack size modification for the Binary manager task seems fine based on the test results mentioned.

Copy link
Contributor

@samsung-singh samsung-singh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reduced stack size of binary manager to 3K in kernel binary manager module, this change is good to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants