os/drivers/lcd/mipi_lcd.c: Add runtime BMP to RGB565 conversion #6990
Conversation
|
Add bmp file(16bit) inside resource directory and modify the variable |
abhinav-s235
force-pushed
the
bmp_to_rgb565
branch
from
8f22a48 to
11f55d9
Compare
|
@abhinav-s235 Is it possible to check converting time for 320 240 and 800 480? |
os/drivers/lcd/mipi_lcd.c
Outdated
|
|
||
| static int lcd_render_bmp(FAR struct lcd_dev_s *dev) | ||
| { | ||
| const char *bmp_filename = "/res/kernel/audio/img_logo_samsung.bmp"; |
There was a problem hiding this comment.
Use bmp_filename as function parameter
There was a problem hiding this comment.
@seokhun-eom24 , How about making the BMP file path configurable in Kconfig?
There was a problem hiding this comment.
@seokhun-eom24 , How about making the BMP file path configurable in Kconfig?
I think it's better to parameterize for function reusability.
Additionally, since the BMP file path needs to be determined dynamically at runtime, we should consider whether Kconfig is more suitable.
There was a problem hiding this comment.
bmp_filename has been parameterized
| } | ||
| } | ||
| priv->config->lcd_put_area((u8 *)fullscreen_buffer, 1, 1, CONFIG_LCD_XRES, CONFIG_LCD_YRES); | ||
| fclose(bmp_file); |
There was a problem hiding this comment.
Also needed mm_free(fullscreen_buffer); in normal exit case.
There was a problem hiding this comment.
In normal exit case when SW_ROTATION is disabled
If I free the buffer the LCD will show some random colours
There was a problem hiding this comment.
Oh you're right. I thought lcd_put_area copies the buffer. So it doesn't need buffer any more.
os/drivers/lcd/mipi_lcd.c
Outdated
| if (r_mask == 0) { | ||
| r = 0; | ||
| } else { | ||
| uint8_t r_bits = __builtin_popcount(r_mask); |
There was a problem hiding this comment.
Need to check with #ifdef __GNUC__ for __builtin_popcount, __builtin_ctz exists.
There was a problem hiding this comment.
added helper functions instead of compiler intrinsics
os/drivers/lcd/mipi_lcd.c
Outdated
| int displayed_img_width = img_height; | ||
| int displayed_img_height = img_width; |
There was a problem hiding this comment.
If these variables are unnecessary, remove them and use img_height and img_width instead
There was a problem hiding this comment.
changes made as you suggested
|
|
||
| int img_width = info_header.width; | ||
| int img_height = info_header.height; | ||
| // For 16-bit, each pixel is 2 bytes. Padding is to the next 4-byte boundary. |
There was a problem hiding this comment.
Can you handle when img_width or img_height is larger than LCD width or height.
goto errout for these cases.
You mean time require to convert bmp file? |
…isplay - This commit introduces a new utility to convert BMP image files to the RGB565 color format and display them on the LCD at runtime. - Supports reading 16-bit files, including handling of `BI_RGB` and `BI_BITFIELDS` compression for 16-bit variants.
abhinav-s235
force-pushed
the
bmp_to_rgb565
branch
from
11f55d9 to
7de15f4
Compare
If its time then it takes around 44ms for 800*480 |
There was a problem hiding this comment.
lcd_render_bmp function should be callable from lcd_init_put_image as you did.
This function must verify the provided file path, return ERROR if the file is missing or an other error occurs, otherwise just render the bmp image to LCD with lcd_put_area
When implementation is completed, change state to mergeable.
4 participants
BI_RGBandBI_BITFIELDScompression for 16-bit variants.