Skip to content

Detach ticket modal focus listener reliably - #10608

Open
Tomeshwari-02 wants to merge 1 commit into
SandeepVashishtha:masterfrom
Tomeshwari-02:fix/10598-ticket-modal-focus-cleanup
Open

Detach ticket modal focus listener reliably#10608
Tomeshwari-02 wants to merge 1 commit into
SandeepVashishtha:masterfrom
Tomeshwari-02:fix/10598-ticket-modal-focus-cleanup

Conversation

@Tomeshwari-02

Copy link
Copy Markdown

Summary

  • capture the modal node before attaching the focus-trap listener
  • remove the listener from the same node during cleanup
  • remove the stale dependency on an effect-local handler

Issue

Closes #10598

Validation

  • npx eslint src\components\common\QRTicket\QRTicketModal.jsx --max-warnings=0

@vercel

vercel Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

@Tomeshwari-02 is attempting to deploy a commit to the sandeepvashishtha's projects Team on Vercel.

A member of the Team first needs to authorize it.

@codescene-access codescene-access Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our agent can fix these. Install it.

No quality gates enabled for this code.

Quality Gate Profile: Custom Configuration
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: QRTicketModal focus trap cleanup can detach from the wrong node

1 participant